diff options
| author | Cherry Zhang <cherryyz@google.com> | 2020-04-02 20:57:44 -0400 |
|---|---|---|
| committer | Cherry Zhang <cherryyz@google.com> | 2020-04-03 13:42:33 +0000 |
| commit | 6117275788ae5f63a1229cf058baf55a818a34c1 (patch) | |
| tree | 29fbeaf47ac6d872dac82370849cf86db9a0f334 | |
| parent | a9a78b7005f400e52d8891b01458539e801cf8ad (diff) | |
| download | go-6117275788ae5f63a1229cf058baf55a818a34c1.tar.gz go-6117275788ae5f63a1229cf058baf55a818a34c1.zip | |
cmd/link: write to temp directory in test
In TestMMap, write to temporary directory, instead of the current
directory (which may not be writeable).
Fix linux-mips64le-mengzhuo builder.
Change-Id: I06dc3266f125523568c543634079c447d91903bb
Reviewed-on: https://go-review.googlesource.com/c/go/+/227077
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
| -rw-r--r-- | src/cmd/link/internal/ld/outbuf_test.go | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/src/cmd/link/internal/ld/outbuf_test.go b/src/cmd/link/internal/ld/outbuf_test.go index 512238f39a..67e4c9c47f 100644 --- a/src/cmd/link/internal/ld/outbuf_test.go +++ b/src/cmd/link/internal/ld/outbuf_test.go @@ -5,7 +5,9 @@ package ld import ( + "io/ioutil" "os" + "path/filepath" "runtime" "testing" ) @@ -17,12 +19,16 @@ func TestMMap(t *testing.T) { t.Skip("unsupported OS") case "darwin", "dragonfly", "freebsd", "linux", "openbsd", "windows": } - filename := "foo.out" + dir, err := ioutil.TempDir("", "TestMMap") + if err != nil { + t.Fatal(err) + } + defer os.RemoveAll(dir) + filename := filepath.Join(dir, "foo.out") ob := NewOutBuf(nil) if err := ob.Open(filename); err != nil { - t.Errorf("error opening file: %v", err) + t.Fatalf("error opening file: %v", err) } - defer os.RemoveAll(filename) defer ob.Close() if err := ob.Mmap(1 << 20); err != nil { t.Errorf("error mmapping file %v", err) |