aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Gerrand <adg@golang.org>2011-09-08 10:49:40 +1000
committerRob Pike <r@golang.org>2011-09-08 10:49:40 +1000
commitd28f559503f50bf40a70211800dca96e22d544da (patch)
tree09aecf3295a9e27641962b251cdd144c0b22c1b6
parentf7e76c75f1bee8f15748b226408d4564ad4004e7 (diff)
downloadgo-d28f559503f50bf40a70211800dca96e22d544da.tar.gz
go-d28f559503f50bf40a70211800dca96e22d544da.zip
[release-branch.r60] gofix: osopen: fixed=true when changing O_CREAT
««« CL 4921047 / 15cefddbe963 gofix: osopen: fixed=true when changing O_CREAT R=rsc, r CC=golang-dev https://golang.org/cl/4921047 »»» R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4961071
-rw-r--r--src/cmd/gofix/osopen.go1
-rw-r--r--src/cmd/gofix/osopen_test.go23
2 files changed, 24 insertions, 0 deletions
diff --git a/src/cmd/gofix/osopen.go b/src/cmd/gofix/osopen.go
index 56147c390e..19c19b5b63 100644
--- a/src/cmd/gofix/osopen.go
+++ b/src/cmd/gofix/osopen.go
@@ -31,6 +31,7 @@ func osopen(f *ast.File) bool {
// Rename O_CREAT to O_CREATE.
if expr, ok := n.(ast.Expr); ok && isPkgDot(expr, "os", "O_CREAT") {
expr.(*ast.SelectorExpr).Sel.Name = "O_CREATE"
+ fixed = true
return
}
diff --git a/src/cmd/gofix/osopen_test.go b/src/cmd/gofix/osopen_test.go
index 43ddd1a40d..a33bcd4fb4 100644
--- a/src/cmd/gofix/osopen_test.go
+++ b/src/cmd/gofix/osopen_test.go
@@ -56,4 +56,27 @@ func f() {
}
`,
},
+ {
+ Name: "osopen.1",
+ In: `package main
+
+import (
+ "os"
+)
+
+func f() {
+ _ = os.O_CREAT
+}
+`,
+ Out: `package main
+
+import (
+ "os"
+)
+
+func f() {
+ _ = os.O_CREATE
+}
+`,
+ },
}