diff options
| author | Cherry Mui <cherryyz@google.com> | 2024-02-20 15:05:29 -0500 |
|---|---|---|
| committer | Carlos Amedee <carlos@golang.org> | 2024-02-27 21:18:11 +0000 |
| commit | 686662f3a461b0bfa585a106ef585220a2a85014 (patch) | |
| tree | 3a5eb8b33d30af4f3e39c42833afd8e867b7b3dc | |
| parent | 6cbe522fe1db19bb7d404d613bb9f2f46ca40655 (diff) | |
| download | go-686662f3a461b0bfa585a106ef585220a2a85014.tar.gz go-686662f3a461b0bfa585a106ef585220a2a85014.zip | |
[release-branch.go1.22] cmd/compile: make jump table symbol static
The jump table symbol is accessed only from the function symbol
(in the same package), so it can be static. Also, if the function
is DUPOK and it is, somehow, compiled differently in two different
packages, the linker must choose the jump table symbol associated
to the function symbol it chose. Currently the jump table symbol
is DUPOK, so that is not guaranteed. Making it static will
guarantee that, as each copy of the function symbol refers to its
own jump table symbol.
Updates #65783.
Fixes #65818.
Change-Id: I27e051d01ef585d07700b75d4dfac5768f16441e
Reviewed-on: https://go-review.googlesource.com/c/go/+/565535
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 290835298067014e906c540d64dcaa706d66b2ce)
Reviewed-on: https://go-review.googlesource.com/c/go/+/566475
| -rw-r--r-- | src/cmd/compile/internal/ssa/rewrite.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/compile/internal/ssa/rewrite.go b/src/cmd/compile/internal/ssa/rewrite.go index fa4208228e..bb09c6cdda 100644 --- a/src/cmd/compile/internal/ssa/rewrite.go +++ b/src/cmd/compile/internal/ssa/rewrite.go @@ -2131,8 +2131,8 @@ func logicFlags32(x int32) flagConstant { func makeJumpTableSym(b *Block) *obj.LSym { s := base.Ctxt.Lookup(fmt.Sprintf("%s.jump%d", b.Func.fe.Func().LSym.Name, b.ID)) - s.Set(obj.AttrDuplicateOK, true) - s.Set(obj.AttrLocal, true) + // The jump table symbol is accessed only from the function symbol. + s.Set(obj.AttrStatic, true) return s } |