diff options
| author | Bryan C. Mills <bcmills@google.com> | 2022-12-02 14:52:34 -0500 |
|---|---|---|
| committer | Michael Pratt <mpratt@google.com> | 2022-12-09 20:04:54 +0000 |
| commit | 0b12684a4a79b93444a3517e4a53e543ce736388 (patch) | |
| tree | b3a55a60711d6589fe6375653f37e008a40229dc | |
| parent | 0d8a92bdfd3d6d1b24f47e05f9be46645aec94f0 (diff) | |
| download | go-0b12684a4a79b93444a3517e4a53e543ce736388.tar.gz go-0b12684a4a79b93444a3517e4a53e543ce736388.zip | |
[release-branch.go1.18] cmd/go: skip TestScript/mod_replace_gopkgin
(Until it can be made hermetic.)
The gopkg.in service has had a lot of flakiness lately. Go users in
general are isolated from that flakiness by the Go module mirror
(proxy.golang.org), but this test intentionally bypasses the module
mirror because the mirror itself uses cmd/go to download the module.
In the long term, we can redirect the gopkg.in URL to the local
(in-process) vcweb server added for #27494.
In the meantime, let's skip the test to reduce the impact of upstream
outages.
Fixes #57057.
Updates #54503.
Change-Id: Icf3de7ca416db548e53864a71776fe22b444fcea
Reviewed-on: https://go-review.googlesource.com/c/go/+/454503
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
(cherry picked from commit c5f5cb659adda026d01b7fa9bd39b2ad3b58c5bf)
Reviewed-on: https://go-review.googlesource.com/c/go/+/454840
| -rw-r--r-- | src/cmd/go/testdata/script/mod_replace_gopkgin.txt | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/cmd/go/testdata/script/mod_replace_gopkgin.txt b/src/cmd/go/testdata/script/mod_replace_gopkgin.txt index df752d9716..8cb034c36c 100644 --- a/src/cmd/go/testdata/script/mod_replace_gopkgin.txt +++ b/src/cmd/go/testdata/script/mod_replace_gopkgin.txt @@ -4,6 +4,9 @@ # even if there is an explicit go.mod file containing the # gopkg.in path. +skip 'skipping test that depends on an unreliable third-party server; see https://go.dev/issue/54503' + # TODO(#54043): Make this test hermetic and re-enable it. + [short] skip [!net] skip [!exec:git] skip |