aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHeschi Kreinick <heschi@google.com>2022-05-10 10:49:40 -0400
committerHeschi Kreinick <heschi@google.com>2022-05-10 15:33:47 +0000
commitf7209f904d45b4c5426cb76992066cdd1cc2f74e (patch)
tree67e23c48c7bb4a0b8473654e84aaa90e207c8c95
parent5b45e19a537f88e0c04dfd91c330e2c52b088c1c (diff)
downloadgo-f7209f904d45b4c5426cb76992066cdd1cc2f74e.tar.gz
go-f7209f904d45b4c5426cb76992066cdd1cc2f74e.zip
[release-branch.go1.17] cmd/objdump: skip TestDisasm* on darwin-arm64
The macOS 12 builders have an incompatible version of XCode installed. We fixed the bug on 1.18 but not 1.17. Updates #49700. Change-Id: Id356786aad351568ba6665430f093f5f78bb4357 Reviewed-on: https://go-review.googlesource.com/c/go/+/405474 Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
-rw-r--r--src/cmd/objdump/objdump_test.go3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/cmd/objdump/objdump_test.go b/src/cmd/objdump/objdump_test.go
index f231a7c6e0..1ce21c46ab 100644
--- a/src/cmd/objdump/objdump_test.go
+++ b/src/cmd/objdump/objdump_test.go
@@ -106,6 +106,9 @@ var ppcGnuNeed = []string{
}
func mustHaveDisasm(t *testing.T) {
+ if strings.HasPrefix(testenv.Builder(), "darwin-arm64") {
+ t.Skipf("builder %q has an incompatible version of XCode installed, see go.dev/issue/49700", testenv.Builder())
+ }
switch runtime.GOARCH {
case "mips", "mipsle", "mips64", "mips64le":
t.Skipf("skipping on %s, issue 12559", runtime.GOARCH)