diff options
| author | Bryan C. Mills <bcmills@google.com> | 2022-02-08 15:07:21 -0500 |
|---|---|---|
| committer | Alex Rakoczy <alex@golang.org> | 2022-05-25 19:23:53 +0000 |
| commit | e846f3f2d602ec5fd4689e14d7530d894b807e70 (patch) | |
| tree | 78eeccf4e38321846743a2544ef007f058fd83af | |
| parent | a9003376d55bcbd5b2b24e199ca861058f84c94c (diff) | |
| download | go-e846f3f2d602ec5fd4689e14d7530d894b807e70.tar.gz go-e846f3f2d602ec5fd4689e14d7530d894b807e70.zip | |
[release-branch.go1.17] runtime: skip TestGdbBacktrace flakes matching a known GDB internal error
TestGdbBacktrace occasionally fails due to a GDB internal error.
We have observed the error on various linux builders since at least
October 2020, and it has been reported upstream at least twice.¹²
Since the bug is external to the Go project and does not appear to be
fixed upstream, this failure mode can only add noise.
¹https://sourceware.org/bugzilla/show_bug.cgi?id=24628
²https://sourceware.org/bugzilla/show_bug.cgi?id=28551
Fixes #53049
Updates #43068
Change-Id: I6c92006a5d730f1c4df54b0307f080b3d643cc6b
Reviewed-on: https://go-review.googlesource.com/c/go/+/384234
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 275aedccd4f2beae82dbf96c94a6c1c9b365a647)
Reviewed-on: https://go-review.googlesource.com/c/go/+/408054
Reviewed-by: Alex Rakoczy <alex@golang.org>
| -rw-r--r-- | src/runtime/runtime-gdb_test.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/runtime/runtime-gdb_test.go b/src/runtime/runtime-gdb_test.go index 8c76a9123c..097d1b5c6a 100644 --- a/src/runtime/runtime-gdb_test.go +++ b/src/runtime/runtime-gdb_test.go @@ -427,6 +427,9 @@ func TestGdbBacktrace(t *testing.T) { got, err := exec.Command("gdb", args...).CombinedOutput() t.Logf("gdb output:\n%s", got) if err != nil { + if bytes.Contains(got, []byte("internal-error: wait returned unexpected status 0x0")) { + testenv.SkipFlaky(t, 43068) + } t.Fatalf("gdb exited with error: %v", err) } |