diff options
| author | Cherry Mui <cherryyz@google.com> | 2022-02-08 14:46:58 -0500 |
|---|---|---|
| committer | Dmitri Shuralyov <dmitshur@golang.org> | 2022-06-29 15:46:29 +0000 |
| commit | 8d2935ab7ccf621443691fa8c103a6decf4fbfb2 (patch) | |
| tree | f9b1da6ab76efc001e5e353747c91d529ca201f7 | |
| parent | 651a8d81baf03a87c244ad317d69cf2ee20fcccd (diff) | |
| download | go-8d2935ab7ccf621443691fa8c103a6decf4fbfb2.tar.gz go-8d2935ab7ccf621443691fa8c103a6decf4fbfb2.zip | |
[release-branch.go1.17] cmd/dist: test cgo internal linking on darwin-arm64
CL 415074 disables testing cgo internal linking on all ARM64 but
Windows, because it doesn't work with newer GCC. But
- darwin-arm64 works, and it does not use GCC
- we don't support cgo internal linking on windows-arm64 anyway.
This CL fixes the condition.
Fixes #53050.
Change-Id: I9eb7b81ef75e482f5e95d2edae4863ba21396432
Reviewed-on: https://go-review.googlesource.com/c/go/+/384269
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit e4ca3fa345a204b72a011b3634ddcfc09dcc68bc)
Reviewed-on: https://go-review.googlesource.com/c/go/+/415075
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
| -rw-r--r-- | src/cmd/dist/test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index a6ea64b495..4f1d556dd4 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -1142,7 +1142,7 @@ func (t *tester) cgoTest(dt *distTest) error { // Skip internal linking cases on arm64 to support GCC-9.4 and above. // See issue #39466. - skipInternalLink := goarch == "arm64" && goos != "windows" + skipInternalLink := goarch == "arm64" && goos != "darwin" if t.internalLink() && !skipInternalLink { cmd := t.addCmd(dt, "misc/cgo/test", t.goTest(), "-tags=internal") |