aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHeschi Kreinick <heschi@google.com>2022-04-26 12:34:35 -0400
committerDmitri Shuralyov <dmitshur@golang.org>2022-05-09 21:42:16 +0000
commit5b45e19a537f88e0c04dfd91c330e2c52b088c1c (patch)
tree89c7fb0c54e6e8a1aea15a772f5eb2001703d10a
parentfeec92c42341ce45f00e7f45341e12a7fef78e53 (diff)
downloadgo-5b45e19a537f88e0c04dfd91c330e2c52b088c1c.tar.gz
go-5b45e19a537f88e0c04dfd91c330e2c52b088c1c.zip
[release-branch.go1.17] net: skip TestDialCancel on darwin-arm64
We're turning up Macs in a network environment that clashes with this test. I don't think it's critical to get it working, so skip it. For #49149. Fixes #52705. Change-Id: I925e3ecc5356c4cefd208bdcff3d98021215d0b4 Reviewed-on: https://go-review.googlesource.com/c/go/+/402181 Reviewed-by: Alex Rakoczy <alex@golang.org> Run-TryBot: Heschi Kreinick <heschi@google.com> Auto-Submit: Heschi Kreinick <heschi@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> (cherry picked from commit 06b0a655a1f46abab2e3c173259ad184b557dd89) Reviewed-on: https://go-review.googlesource.com/c/go/+/405295 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com>
-rw-r--r--src/net/dial_test.go6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/net/dial_test.go b/src/net/dial_test.go
index 723038c7a2..8f6dd714db 100644
--- a/src/net/dial_test.go
+++ b/src/net/dial_test.go
@@ -751,6 +751,12 @@ func TestDialerKeepAlive(t *testing.T) {
func TestDialCancel(t *testing.T) {
mustHaveExternalNetwork(t)
+ if strings.HasPrefix(testenv.Builder(), "darwin-arm64") {
+ // The darwin-arm64 machines run in an environment that's not
+ // compatible with this test.
+ t.Skipf("builder %q gives no route to host for 198.18.0.0", testenv.Builder())
+ }
+
blackholeIPPort := JoinHostPort(slowDst4, "1234")
if !supportsIPv4() {
blackholeIPPort = JoinHostPort(slowDst6, "1234")