diff options
| author | Michael Fraenkel <michael.fraenkel@gmail.com> | 2021-05-13 09:41:45 -0600 |
|---|---|---|
| committer | Dmitri Shuralyov <dmitshur@golang.org> | 2021-06-02 01:35:23 +0000 |
| commit | 1613be84815e34b2c803694ac073b2ae67f18168 (patch) | |
| tree | c5b1332403e375984862a32331bf354553f09767 | |
| parent | 0410005dc458f23fb15f64354f9a24ca8f2fe044 (diff) | |
| download | go-1613be84815e34b2c803694ac073b2ae67f18168.tar.gz go-1613be84815e34b2c803694ac073b2ae67f18168.zip | |
[release-branch.go1.16] net/http: prevent infinite wait during TestMissingStatusNoPanic
If the client request never makes it to the server, the outstanding
accept is never broken. Change the test to always close the listening
socket when the client request completes.
Updates #45358
Change-Id: I744a91dfa11704e7e528163d7669c394e90456dc
Reviewed-on: https://go-review.googlesource.com/c/go/+/319275
Trust: Heschi Kreinick <heschi@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit c0a7ecfae775a9d50d338e8123fac32a5d04308c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/320190
Reviewed-by: Damien Neil <dneil@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
| -rw-r--r-- | src/net/http/transport_test.go | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/src/net/http/transport_test.go b/src/net/http/transport_test.go index ba85a61683..73d259dc9a 100644 --- a/src/net/http/transport_test.go +++ b/src/net/http/transport_test.go @@ -5314,7 +5314,6 @@ func TestMissingStatusNoPanic(t *testing.T) { ln := newLocalListener(t) addr := ln.Addr().String() - shutdown := make(chan bool, 1) done := make(chan bool) fullAddrURL := fmt.Sprintf("http://%s", addr) raw := "HTTP/1.1 400\r\n" + @@ -5326,10 +5325,7 @@ func TestMissingStatusNoPanic(t *testing.T) { "Aloha Olaa" go func() { - defer func() { - ln.Close() - close(done) - }() + defer close(done) conn, _ := ln.Accept() if conn != nil { @@ -5360,7 +5356,7 @@ func TestMissingStatusNoPanic(t *testing.T) { t.Errorf("got=%v want=%q", err, want) } - close(shutdown) + ln.Close() <-done } |