diff options
| author | Jay Conrod <jayconrod@google.com> | 2020-01-21 14:50:36 -0800 |
|---|---|---|
| committer | Carlos Amedee <carlos@golang.org> | 2020-02-26 17:04:28 +0000 |
| commit | 20a2e0a58454cbfa4aa32c673c87859d4cf6c52c (patch) | |
| tree | 4071f6ebc9333e4e5097aa3fbb962f067db2c003 | |
| parent | 0e115a326648cd650f833a175c0505774413d9db (diff) | |
| download | go-20a2e0a58454cbfa4aa32c673c87859d4cf6c52c.tar.gz go-20a2e0a58454cbfa4aa32c673c87859d4cf6c52c.zip | |
[release-branch.go1.13] cmd/go: add -d flag to mod_get_test
'go get all' was run in this test without -d. This caused some std
packages to be reinstalled if the test is run in a slightly different
configuration than make.bash was run. run.bash would fail in some
situations because of this. Nothing in the cmd/go tests should modify
installed std or cmd packages.
Updates #36846
Updates #35459
Change-Id: Idd259a27d55502923b7fc54f361a77f0ac11eea2
Reviewed-on: https://go-review.googlesource.com/c/go/+/215721
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
(cherry picked from commit 71bbffbc48d03b447c73da1f54ac57350fc9b36a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/218597
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
| -rw-r--r-- | src/cmd/go/testdata/script/mod_get_test.txt | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/go/testdata/script/mod_get_test.txt b/src/cmd/go/testdata/script/mod_get_test.txt index f921168ad4..3680ca273d 100644 --- a/src/cmd/go/testdata/script/mod_get_test.txt +++ b/src/cmd/go/testdata/script/mod_get_test.txt @@ -33,7 +33,7 @@ grep 'rsc.io/quote v1.5.1$' go.mod # 'go get all' should consider test dependencies with or without -t. cp go.mod.empty go.mod -go get all +go get -d all grep 'rsc.io/quote v1.5.2$' go.mod -- go.mod.empty -- |