diff options
| author | Bryan C. Mills <bcmills@google.com> | 2019-11-05 11:01:10 -0500 |
|---|---|---|
| committer | Bryan C. Mills <bcmills@google.com> | 2019-12-11 18:53:16 +0000 |
| commit | e4e29ee62b044b665881f4b220ee2204ad892a57 (patch) | |
| tree | 05d72e1f79076bb7fe03f9be47ee3384760efcf3 | |
| parent | 741cb42f83b8b154e2876035cdf74e4e81a41a6f (diff) | |
| download | go-e4e29ee62b044b665881f4b220ee2204ad892a57.tar.gz go-e4e29ee62b044b665881f4b220ee2204ad892a57.zip | |
[release-branch.go1.12] cmd/go/internal/modfetch: remove non-hermetic test
The test for gopkg.in/yaml.v2@v2 assumes that there are
no future upstream releases. That assumption empirically
does not hold. Backporting fixes to this test is annoying,
and other gopkg.in cases are already reasonably covered,
so remove the problematic test.
Updates #28856
Change-Id: I6455baa1816ac69e02d1ad5d03b82a93e1481a17
Reviewed-on: https://go-review.googlesource.com/c/go/+/205437
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit f0390ffc9d461cb84207b5a94c4b645c87673406)
Reviewed-on: https://go-review.googlesource.com/c/go/+/205439
Reviewed-by: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
| -rw-r--r-- | src/cmd/go/internal/modfetch/coderepo_test.go | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/src/cmd/go/internal/modfetch/coderepo_test.go b/src/cmd/go/internal/modfetch/coderepo_test.go index f9d19f751e..f2e44a00cd 100644 --- a/src/cmd/go/internal/modfetch/coderepo_test.go +++ b/src/cmd/go/internal/modfetch/coderepo_test.go @@ -284,15 +284,6 @@ var codeRepoTests = []struct { gomod: "module gopkg.in/check.v1\n", }, { - path: "gopkg.in/yaml.v2", - rev: "v2", - version: "v2.2.5-0.20191002202810-970885f01c8b", - name: "970885f01c8bc1fecb7ab1c8ce8e7609bda45530", - short: "970885f01c8b", - time: time.Date(2019, 10, 2, 20, 28, 10, 0, time.UTC), - gomod: "module \"gopkg.in/yaml.v2\"\n\nrequire (\n\t\"gopkg.in/check.v1\" v0.0.0-20161208181325-20d25e280405\n)\n", - }, - { path: "vcs-test.golang.org/go/mod/gitrepo1", rev: "master", version: "v1.2.4-annotated", |