diff options
| author | Bryan C. Mills <bcmills@google.com> | 2019-03-05 17:01:19 -0500 |
|---|---|---|
| committer | Filippo Valsorda <filippo@golang.org> | 2019-10-08 20:05:42 +0000 |
| commit | d7dd91aa4c698c86e884c92a20c5fbb0e4b6db8e (patch) | |
| tree | cf97022c241e6b4575526a885af320242662b9b9 | |
| parent | 273d946ec451a0722d21ac12494be7e367bbaac6 (diff) | |
| download | go-d7dd91aa4c698c86e884c92a20c5fbb0e4b6db8e.tar.gz go-d7dd91aa4c698c86e884c92a20c5fbb0e4b6db8e.zip | |
[release-branch.go1.12] cmd/go: clear GOPROXY in TestGoGetInsecure
TestGoGetInsecure verifies that 'go get -insecure' can fetch a
particular package. However, the GOPROXY protocol does not provide a
means for proxies to indicate packages as insecure; thus, proxies
cannot safely serve those packages.
This also squashes the typo fix from CL 167086.
Updates #30571
Fixes #33758
Change-Id: I447776dff98bd8ee6eb5055b897b9c7d293e3423
Reviewed-on: https://go-review.googlesource.com/c/go/+/165745
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/199820
Run-TryBot: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
| -rw-r--r-- | src/cmd/go/go_test.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go index c58bc7408d..1c3dcd851b 100644 --- a/src/cmd/go/go_test.go +++ b/src/cmd/go/go_test.go @@ -3639,6 +3639,7 @@ func TestGoGetInsecure(t *testing.T) { tg.tempFile("go.mod", "module m") tg.cd(tg.path(".")) tg.setenv("GO111MODULE", "on") + tg.setenv("GOPROXY", "") } else { tg.setenv("GOPATH", tg.path(".")) tg.setenv("GO111MODULE", "off") |