diff options
author | Brad Fitzpatrick <bradfitz@golang.org> | 2017-07-27 04:33:18 +0000 |
---|---|---|
committer | Brad Fitzpatrick <bradfitz@golang.org> | 2017-07-27 05:04:28 +0000 |
commit | 45a4609c0ae214e448612e0bc0846e2f2682f1b2 (patch) | |
tree | 989f9c44febd4f0e8ea856e8e273d3eac151e9ad | |
parent | e157fac02d4700e9fa8e1c30265a2d90a51be6f3 (diff) | |
download | go-45a4609c0ae214e448612e0bc0846e2f2682f1b2.tar.gz go-45a4609c0ae214e448612e0bc0846e2f2682f1b2.zip |
cmd/dist: skip moved GOROOT on Go's Windows builders when not sharding tests
Change-Id: I0bcae339624e7d61037d9ea0885b7bd07491bbb6
Reviewed-on: https://go-review.googlesource.com/51430
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
-rw-r--r-- | src/cmd/dist/test.go | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 6846970ecf..73432d31ea 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -447,6 +447,17 @@ func (t *tester) registerTests() { t.runPending(dt) moved := t.goroot + "-moved" if err := os.Rename(t.goroot, moved); err != nil { + if t.goos == "windows" { + // Fails on Windows (with "Access is denied") if a process + // or binary is in this directory. For instance, using all.bat + // when run from c:\workdir\go\src fails here + // if GO_BUILDER_NAME is set. Our builders invoke tests + // a different way which happens to work when sharding + // tests, but we should be tolerant of the non-sharded + // all.bat case. + log.Printf("skipping test on Windows") + return nil + } return err } |