aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorElias Naur <elias.naur@gmail.com>2017-01-29 23:57:14 +0100
committerBrad Fitzpatrick <bradfitz@golang.org>2017-01-29 23:31:20 +0000
commit4cffe2b604d0980e6fb9b994b31f69c53045a460 (patch)
tree3ac4a6dce74e73724234d06dc326a7e4d9b63c50
parent6bdb0c11c73ecf2337918d784c54f9dda2207ca7 (diff)
downloadgo-4cffe2b604d0980e6fb9b994b31f69c53045a460.tar.gz
go-4cffe2b604d0980e6fb9b994b31f69c53045a460.zip
cmd/dist: use the target GOOS to skip the test for issue 18153
Fixes (skips) the test on Android, where stdout/stderr are not terminals. Updates #18153 Change-Id: Ieca65150362a5c423747ad751e00f76f0b890746 Reviewed-on: https://go-review.googlesource.com/35957 Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-rw-r--r--src/cmd/dist/test.go3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go
index 7d5f79f339..8ad4a8620d 100644
--- a/src/cmd/dist/test.go
+++ b/src/cmd/dist/test.go
@@ -15,7 +15,6 @@ import (
"os/exec"
"path/filepath"
"regexp"
- "runtime"
"strconv"
"strings"
"sync"
@@ -354,7 +353,7 @@ func (t *tester) registerTests() {
// This test needs its stdout/stderr to be terminals, so we don't run it from cmd/go's tests.
// See issue 18153.
- if runtime.GOOS == "linux" {
+ if t.goos == "linux" {
t.tests = append(t.tests, distTest{
name: "cmd_go_test_terminal",
heading: "cmd/go terminal test",