aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrad Fitzpatrick <bradfitz@golang.org>2016-07-16 23:56:45 +0000
committerBrad Fitzpatrick <bradfitz@golang.org>2016-07-17 01:25:19 +0000
commita6dbfc12c640c90e8dc552443d3ece04cbae4a9c (patch)
tree9cd94d4ec075a86851bb2b446fea8ab2ae8c5f19
parent510fb6397dfc93067dc90d42c58dfc5f8b995285 (diff)
downloadgo-a6dbfc12c640c90e8dc552443d3ece04cbae4a9c.tar.gz
go-a6dbfc12c640c90e8dc552443d3ece04cbae4a9c.zip
net: demote TestDialerDualStack to a flaky test
Only run TestDialerDualStack on the builders, as to not annoy or otherwise distract users when it's not their fault. Even though the intention is to only run this on the builders, very few of the builders have IPv6 support. Oh well. We'll get some coverage. Updates #13324 Change-Id: I13e7e3bca77ac990d290cabec88984cc3d24fb67 Reviewed-on: https://go-review.googlesource.com/24985 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
-rw-r--r--src/net/dial_test.go5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/net/dial_test.go b/src/net/dial_test.go
index 9fe507e901..8b21e6b088 100644
--- a/src/net/dial_test.go
+++ b/src/net/dial_test.go
@@ -695,6 +695,11 @@ func TestDialerLocalAddr(t *testing.T) {
}
func TestDialerDualStack(t *testing.T) {
+ // This test is known to be flaky. Don't frighten regular
+ // users about it; only fail on the build dashboard.
+ if testenv.Builder() == "" {
+ testenv.SkipFlaky(t, 13324)
+ }
if !supportsIPv4 || !supportsIPv6 {
t.Skip("both IPv4 and IPv6 are required")
}