aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIan Lance Taylor <iant@golang.org>2016-06-08 17:45:55 -0700
committerIan Lance Taylor <iant@golang.org>2016-06-09 03:48:34 +0000
commit763883632e4d7fea145b6f3a7ee501b5ad9096f2 (patch)
tree6e84b883b49a0685f09ffa70790ad2f6a75b1eb2
parentf3689d138256c36dbe0004459f79d570f5345f74 (diff)
downloadgo-763883632e4d7fea145b6f3a7ee501b5ad9096f2.tar.gz
go-763883632e4d7fea145b6f3a7ee501b5ad9096f2.zip
cmd/go: only run TestGoGetHTTPS404 where it works
The test TestGoGetHTTPS404 downloads a package that does not build on every OS, so change it to only run where the package builds. It's not great for the test to depend on an external package, but this is an improvement on the current situation. Fixes #15644. Change-Id: I1679cee5ab1e61a5b26f4ad39dc8a397fbc0da69 Reviewed-on: https://go-review.googlesource.com/23920 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Andrew Gerrand <adg@golang.org>
-rw-r--r--src/cmd/go/go_test.go5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go
index 1bee5e6609..c46e0c7da5 100644
--- a/src/cmd/go/go_test.go
+++ b/src/cmd/go/go_test.go
@@ -2358,6 +2358,11 @@ func TestGoGetRscIoToolstash(t *testing.T) {
// Issue 13037: Was not parsing <meta> tags in 404 served over HTTPS
func TestGoGetHTTPS404(t *testing.T) {
testenv.MustHaveExternalNetwork(t)
+ switch runtime.GOOS {
+ case "darwin", "linux", "freebsd":
+ default:
+ t.Skipf("test case does not work on %s", runtime.GOOS)
+ }
tg := testgo(t)
defer tg.cleanup()