aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKeith Randall <khr@golang.org>2016-06-07 09:54:09 -0700
committerKeith Randall <khr@golang.org>2016-06-07 17:34:48 +0000
commit41dd1696ab13755bf7a129e0c73523ffb9fcbe66 (patch)
tree10460ce37b76f17768ba9788a1cb34acfa83ef3c
parent2f088884aeab7f34ca69c0b8ab21c9694c628e19 (diff)
downloadgo-41dd1696ab13755bf7a129e0c73523ffb9fcbe66.tar.gz
go-41dd1696ab13755bf7a129e0c73523ffb9fcbe66.zip
cmd/compile: fix heap dump test on android
go_android_exec is looking for "exitcode=" to decide the result of running a test. The heap dump test nondeterministically prints "finalized" right at the end of the test. When the timing is just right, we print "finalizedexitcode=0" and confuse go_android_exec. This failure happens occasionally on the android builders. Change-Id: I4f73a4db05d8f40047ecd3ef3a881a4ae3741e26 Reviewed-on: https://go-review.googlesource.com/23861 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Crawshaw <crawshaw@golang.org>
-rw-r--r--src/runtime/debug/heapdump_test.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/runtime/debug/heapdump_test.go b/src/runtime/debug/heapdump_test.go
index 5761c015b8..7d5b950895 100644
--- a/src/runtime/debug/heapdump_test.go
+++ b/src/runtime/debug/heapdump_test.go
@@ -38,7 +38,7 @@ type Obj struct {
}
func objfin(x *Obj) {
- println("finalized", x)
+ //println("finalized", x)
}
func TestWriteHeapDumpFinalizers(t *testing.T) {