diff options
| author | Russ Cox <rsc@golang.org> | 2015-12-16 22:40:15 -0500 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2015-12-17 05:46:21 +0000 |
| commit | 37f2afa625204befc21837756d5e64fe0ffcd7d5 (patch) | |
| tree | 12c2f4ddf14021598d7c5a8a11273109fe94b0b5 | |
| parent | 4378746a4b4160d5851d1daa68383a514aadad6f (diff) | |
| download | go-37f2afa625204befc21837756d5e64fe0ffcd7d5.tar.gz go-37f2afa625204befc21837756d5e64fe0ffcd7d5.zip | |
cmd/go: disable use of -linkmode=external in tests when CGO_ENABLED=0
If cgo is turned off, there may not be an external linker available.
Fixes #13450.
Change-Id: Idbf3f3f57b4bb3908b67264f96d276acc952102a
Reviewed-on: https://go-review.googlesource.com/17941
Reviewed-by: Ian Lance Taylor <iant@golang.org>
| -rw-r--r-- | src/cmd/go/note_test.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/cmd/go/note_test.go b/src/cmd/go/note_test.go index bfaa75f6c3..811734b377 100644 --- a/src/cmd/go/note_test.go +++ b/src/cmd/go/note_test.go @@ -6,6 +6,7 @@ package main_test import ( main "cmd/go" + "go/build" "runtime" "testing" ) @@ -42,6 +43,8 @@ func testNoteReading(t *testing.T) { } switch { + case !build.Default.CgoEnabled: + t.Skipf("skipping - no cgo, so assuming external linking not available") case runtime.GOOS == "linux" && (runtime.GOARCH == "ppc64le" || runtime.GOARCH == "ppc64"): t.Skipf("skipping - external linking not supported, golang.org/issue/11184") case runtime.GOOS == "linux" && (runtime.GOARCH == "mips64le" || runtime.GOARCH == "mips64"): |