diff options
author | Andrew Gerrand <adg@golang.org> | 2013-11-01 11:22:39 +1100 |
---|---|---|
committer | Andrew Gerrand <adg@golang.org> | 2013-11-01 11:22:39 +1100 |
commit | 153283b74b412dc9202f69395d07858a3e42e210 (patch) | |
tree | e76ecc43c748460abc6e461def4e349319743762 | |
parent | 038ff9dca156c92527167dd15f6da918b6f91648 (diff) | |
download | go-153283b74b412dc9202f69395d07858a3e42e210.tar.gz go-153283b74b412dc9202f69395d07858a3e42e210.zip |
[release-branch.go1.2] cmd/cgo: stop using -fno-eliminate-unused-debug-types
««« CL 18850043 / 5ef4bf9eb256
cmd/cgo: stop using -fno-eliminate-unused-debug-types
This flag was added in January 2010, in CL 181102, to fix issue 497.
(Numbers were just shorter back then.) The fix was for OS X machines
and the llvm-gcc frontend.
In July 2011 we had to change the way we get enum values, because
there were no flags available to force Xcode's llvm-gcc to include the
enum names and values in DWARF debug output.
We now use clang, not llvm-gcc, on OS X machines.
Earlier versions of clang printed a warning about not knowing the flag.
Newer versions of clang now make that an error.
That is:
- The flag was added for OS X machines.
- The flag is no longer necessary on OS X machines.
- The flag now breaks some OS X machines.
Remove it.
I have run the original program from issue 497 successfully
without the flag on both OS X and Linux machines.
Fixes #6678.
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/18850043
»»»
R=golang-dev
CC=golang-dev
https://golang.org/cl/19850048
-rw-r--r-- | src/cmd/cgo/gcc.go | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/src/cmd/cgo/gcc.go b/src/cmd/cgo/gcc.go index d31fc47f1a..60d420b21f 100644 --- a/src/cmd/cgo/gcc.go +++ b/src/cmd/cgo/gcc.go @@ -742,13 +742,12 @@ func gccTmp() string { // the input. func (p *Package) gccCmd() []string { c := append(p.gccBaseCmd(), - "-w", // no warnings - "-Wno-error", // warnings are not errors - "-o"+gccTmp(), // write object to tmp - "-gdwarf-2", // generate DWARF v2 debugging symbols - "-fno-eliminate-unused-debug-types", // gets rid of e.g. untyped enum otherwise - "-c", // do not link - "-xc", // input language is C + "-w", // no warnings + "-Wno-error", // warnings are not errors + "-o"+gccTmp(), // write object to tmp + "-gdwarf-2", // generate DWARF v2 debugging symbols + "-c", // do not link + "-xc", // input language is C ) if strings.Contains(c[0], "clang") { c = append(c, |