aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCuong Manh Le <cuong.manhle.vn@gmail.com>2023-08-10 01:51:17 +0700
committerGopher Robot <gobot@golang.org>2023-08-17 21:07:51 +0000
commit25c6dce1882795b64988bdf634282e7512842650 (patch)
treed8257df2b6aeec5d4bd7c6a79faf2651db9531fb
parent4e34f2e81d5be77aeffecf67ad4f02af6a6ec0f9 (diff)
downloadgo-25c6dce1882795b64988bdf634282e7512842650.tar.gz
go-25c6dce1882795b64988bdf634282e7512842650.zip
[release-branch.go1.21] cmd/compile: make backingArrayPtrLen to return typecheck-ed nodes
Fixes #61909 Change-Id: Ief8e3a6c42c0644c9f71ebef5f28a294cd7c153f Reviewed-on: https://go-review.googlesource.com/c/go/+/517936 Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/518115 Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
-rw-r--r--src/cmd/compile/internal/walk/walk.go2
-rw-r--r--test/fixedbugs/issue61908.go16
2 files changed, 18 insertions, 0 deletions
diff --git a/src/cmd/compile/internal/walk/walk.go b/src/cmd/compile/internal/walk/walk.go
index 778b95d547..149e23ab7c 100644
--- a/src/cmd/compile/internal/walk/walk.go
+++ b/src/cmd/compile/internal/walk/walk.go
@@ -278,8 +278,10 @@ func backingArrayPtrLen(n ir.Node) (ptr, length ir.Node) {
} else {
ptr.SetType(n.Type().Elem().PtrTo())
}
+ ptr.SetTypecheck(1)
length = ir.NewUnaryExpr(base.Pos, ir.OLEN, n)
length.SetType(types.Types[types.TINT])
+ length.SetTypecheck(1)
return ptr, length
}
diff --git a/test/fixedbugs/issue61908.go b/test/fixedbugs/issue61908.go
new file mode 100644
index 0000000000..f5d3bce678
--- /dev/null
+++ b/test/fixedbugs/issue61908.go
@@ -0,0 +1,16 @@
+// compile
+
+// Copyright 2023 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package p
+
+func f(p []byte) int {
+ switch "" < string(p) {
+ case true:
+ return 0
+ default:
+ return 1
+ }
+}