diff options
| author | Ian Lance Taylor <iant@golang.org> | 2022-12-09 11:22:32 -0800 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-12-14 20:48:40 +0000 |
| commit | 45ba8ba9f60da6f9f70716b4b7b1eda4daa481b5 (patch) | |
| tree | ab2eb1e2e025f0b373dcdb07a8d47e0386cae4dd | |
| parent | 926ffba40bb44ef931d4b7397bd381b417cbbc9b (diff) | |
| download | go-45ba8ba9f60da6f9f70716b4b7b1eda4daa481b5.tar.gz go-45ba8ba9f60da6f9f70716b4b7b1eda4daa481b5.zip | |
[release-branch.go1.19] os: skip size test in TestLstat if the file is a symlink
Tested by temporarily changing sysdir to use a directory where
the expected files were all symlinks. We should consider using
a different approach that doesn't rely on sysdir, but for now
do a minimal fix.
For #57210
Fixes #57214
Change-Id: Ifb1becef03e014ceb48290ce13527b3e103c0e07
Reviewed-on: https://go-review.googlesource.com/c/go/+/456557
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 9b8750f53ed89fb326e4d811524e647683136bac)
Reviewed-on: https://go-review.googlesource.com/c/go/+/456560
Reviewed-by: Austin Clements <austin@google.com>
| -rw-r--r-- | src/os/os_test.go | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/os/os_test.go b/src/os/os_test.go index 045668a274..ad44f36f4b 100644 --- a/src/os/os_test.go +++ b/src/os/os_test.go @@ -275,9 +275,11 @@ func TestLstat(t *testing.T) { if !equal(sfname, dir.Name()) { t.Error("name should be ", sfname, "; is", dir.Name()) } - filesize := size(path, t) - if dir.Size() != filesize { - t.Error("size should be", filesize, "; is", dir.Size()) + if dir.Mode()&ModeSymlink == 0 { + filesize := size(path, t) + if dir.Size() != filesize { + t.Error("size should be", filesize, "; is", dir.Size()) + } } } |