diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2020-11-08 11:11:27 +0100 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2020-12-14 22:39:04 +0000 |
| commit | 663cd862edf8dfa9c78d9df0f372c9bea03139e4 (patch) | |
| tree | 21011e00f89d2939d793d60c83ddd7103ce93004 | |
| parent | 48dfa2b2dca43c6dc80d7e1d1c605e2918fad3af (diff) | |
| download | go-663cd862edf8dfa9c78d9df0f372c9bea03139e4.tar.gz go-663cd862edf8dfa9c78d9df0f372c9bea03139e4.zip | |
cmd/link: do not mark resource section as writable
Resources are immutable, and all other linkers set this section to be
read-only and not read-write. Fix this oversight by removing the writable
flag.
Change-Id: Ib441bde6620be2000f1685df1ea7bfaebdbe7860
Reviewed-on: https://go-review.googlesource.com/c/go/+/268258
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Trust: Alex Brainman <alex.brainman@gmail.com>
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
| -rw-r--r-- | src/cmd/link/internal/ld/pe.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/link/internal/ld/pe.go b/src/cmd/link/internal/ld/pe.go index d60aa55c36..adbf516d5c 100644 --- a/src/cmd/link/internal/ld/pe.go +++ b/src/cmd/link/internal/ld/pe.go @@ -1524,7 +1524,7 @@ func addpersrc(ctxt *Link) { data := ctxt.loader.Data(rsrcsym) size := len(data) h := pefile.addSection(".rsrc", size, size) - h.characteristics = IMAGE_SCN_MEM_READ | IMAGE_SCN_MEM_WRITE | IMAGE_SCN_CNT_INITIALIZED_DATA + h.characteristics = IMAGE_SCN_MEM_READ | IMAGE_SCN_CNT_INITIALIZED_DATA h.checkOffset(ctxt.Out.Offset()) // relocation |