diff options
| author | Than McIntosh <thanm@google.com> | 2019-06-19 13:33:33 -0400 |
|---|---|---|
| committer | Than McIntosh <thanm@google.com> | 2019-06-19 19:23:51 +0000 |
| commit | 26954bde4443c4bfbfe7608f35584b6b810f3f2c (patch) | |
| tree | 90241e9feff260a15ae3ed8ced1ff0c636040822 | |
| parent | b373d31c25e58d0b69cff3521b915f0c06fa6ac8 (diff) | |
| download | go-26954bde4443c4bfbfe7608f35584b6b810f3f2c.tar.gz go-26954bde4443c4bfbfe7608f35584b6b810f3f2c.zip | |
cmd/link: macos: set initial protection of 0 for __DWARF segment
For later versions of MacOS, the dynamic loader is more picky about
enforcing restrictions on __DWARF MachO load commands/segments,
triggering aborts of the form
dyld: malformed mach-o image: segment __DWARF has vmsize < filesize
for Go programs that use cgo on Darwin. The error is being triggered
because the Go linker is setting "vmsize" in the DWARF segment entry
to zero as a way to signal that the DWARF doesn't need to be mapped
into memory at runtime (which we need to continue to do).
This patch changes the initial protection on the __DWARF segment to
zero, which dyld seems to be happy with (this is used for other similar
non-loadable sections such as __LLVM).
Fixes #32673
Change-Id: I9a73449c6d26c172f3d70361719943af381f37e6
Reviewed-on: https://go-review.googlesource.com/c/go/+/182958
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
| -rw-r--r-- | src/cmd/link/internal/ld/macho_combine_dwarf.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/cmd/link/internal/ld/macho_combine_dwarf.go b/src/cmd/link/internal/ld/macho_combine_dwarf.go index dd2ab4c5b0..3c123a092f 100644 --- a/src/cmd/link/internal/ld/macho_combine_dwarf.go +++ b/src/cmd/link/internal/ld/macho_combine_dwarf.go @@ -409,6 +409,7 @@ func machoUpdateDwarfHeader(r *loadCmdReader, buildmode BuildMode, compressedSec segv := reflect.ValueOf(seg).Elem() segv.FieldByName("Offset").SetUint(uint64(dwarfstart)) segv.FieldByName("Addr").SetUint(uint64(dwarfaddr)) + segv.FieldByName("Prot").SetUint(0) if compressedSects != nil { var segSize uint64 |