diff options
| author | Jay Conrod <jayconrod@google.com> | 2019-01-03 18:33:36 -0500 |
|---|---|---|
| committer | Jay Conrod <jayconrod@google.com> | 2019-01-04 00:13:43 +0000 |
| commit | 9a7278ae47fd2ef9675e4303409e726e429d64e3 (patch) | |
| tree | 6c910676af371ebd6ff5cfebed72e878bc575244 | |
| parent | af134b17da99344812344bba65247e45fa22d53b (diff) | |
| download | go-9a7278ae47fd2ef9675e4303409e726e429d64e3.tar.gz go-9a7278ae47fd2ef9675e4303409e726e429d64e3.zip | |
cmd/go: fix failure in TestScript/build_runtime_gcflags
This test case failed on the longtest builder. It relied on
runtime/internal/atomic not being compiled with the -l flag in the
cache. The test case now creates its own GOCACHE, similar to
build_cache_compile and a few others.
Also, mention the correct issue the test case verifies.
Fixes #29395
Change-Id: Id50e9dfc50db03fb11582d3dd6b69c3e1ed750eb
Reviewed-on: https://go-review.googlesource.com/c/156237
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
| -rw-r--r-- | src/cmd/go/testdata/script/build_runtime_gcflags.txt | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/cmd/go/testdata/script/build_runtime_gcflags.txt b/src/cmd/go/testdata/script/build_runtime_gcflags.txt index dc0767c569..767b768b82 100644 --- a/src/cmd/go/testdata/script/build_runtime_gcflags.txt +++ b/src/cmd/go/testdata/script/build_runtime_gcflags.txt @@ -1,4 +1,8 @@ -# This test verifies the standard library (specifically runtime/internal/atomic) -# can be built with -gcflags when -n is given. See golang.org/issue/26092. +# Set up fresh GOCACHE. +env GOCACHE=$WORK/gocache +mkdir $GOCACHE + +# Verify the standard library (specifically runtime/internal/atomic) can be +# built with -gcflags when -n is given. See golang.org/issue/29346. go build -n -gcflags=all='-l' std stderr 'compile.* -l .* runtime/internal/atomic' |