aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKeith Randall <khr@google.com>2018-07-17 15:07:26 -0700
committerKeith Randall <khr@golang.org>2018-07-19 16:24:53 +0000
commit59d0baeb335647663b135a52af5d345d989f218f (patch)
tree1d3f306fda9e035ee4e70ffe28479f7cc7603d2d
parentf3582de3a0d4d9fb14763494cc4def548042274f (diff)
downloadgo-59d0baeb335647663b135a52af5d345d989f218f.tar.gz
go-59d0baeb335647663b135a52af5d345d989f218f.zip
cmd/compile: add test for OPmodify ops clobbering flags
Code fix was in CL 122556. This is a corresponding test case. Fixes #26426 Change-Id: Ib8769f367aed8bead029da0a8d2ddccee1d1dccb Reviewed-on: https://go-review.googlesource.com/124535 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-rw-r--r--test/fixedbugs/issue26426.go29
1 files changed, 29 insertions, 0 deletions
diff --git a/test/fixedbugs/issue26426.go b/test/fixedbugs/issue26426.go
new file mode 100644
index 0000000000..4f2a452faa
--- /dev/null
+++ b/test/fixedbugs/issue26426.go
@@ -0,0 +1,29 @@
+//run
+
+// Copyright 2018 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package main
+
+//go:noinline
+func f(p *int, v int, q1, q2 *int, r *bool) {
+ x := *r
+ if x {
+ *q1 = 1
+ }
+ *p = *p + v // This must clobber flags. Otherwise we keep x in a flags register.
+ if x {
+ *q2 = 1
+ }
+}
+
+func main() {
+ var p int
+ var q1, q2 int
+ var b bool
+ f(&p, 1, &q1, &q2, &b)
+ if q1 != 0 || q2 != 0 {
+ panic("bad")
+ }
+}