aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKeith Randall <keithr@alum.mit.edu>2019-01-03 11:03:19 -0800
committerKatie Hockman <katie@golang.org>2019-01-04 20:48:27 +0000
commit84f1e9214470af0998b7774f8abc995c3bd06cbb (patch)
tree4184b04fe80cafbd4bbced9d89eb3e3059c4cde7
parentc36b5322a7bcb268fa7a4b5ef67ce807745745a9 (diff)
downloadgo-84f1e9214470af0998b7774f8abc995c3bd06cbb.tar.gz
go-84f1e9214470af0998b7774f8abc995c3bd06cbb.zip
[release-branch.go1.11] runtime: add test for go function argument scanning
Derived from Naoki's reproducer. Update #29565 Change-Id: I1cbd33b38a2f74905dbc22c5ecbad4a87a24bdd1 Reviewed-on: https://go-review.googlesource.com/c/156122 Run-TryBot: Keith Randall <khr@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> (cherry picked from commit af4320350b3a156de0d1cfa9845ab1e48dcbfefa) Reviewed-on: https://go-review.googlesource.com/c/156358 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-rw-r--r--test/fixedbugs/issue29362.go42
1 files changed, 42 insertions, 0 deletions
diff --git a/test/fixedbugs/issue29362.go b/test/fixedbugs/issue29362.go
new file mode 100644
index 0000000000..a8bd607c4a
--- /dev/null
+++ b/test/fixedbugs/issue29362.go
@@ -0,0 +1,42 @@
+// run
+
+// Copyright 2018 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// Verify that we don't consider a Go'd function's
+// arguments as pointers when they aren't.
+
+package main
+
+import (
+ "unsafe"
+)
+
+var badPtr uintptr
+
+var sink []byte
+
+func init() {
+ // Allocate large enough to use largeAlloc.
+ b := make([]byte, 1<<16-1)
+ sink = b // force heap allocation
+ // Any space between the object and the end of page is invalid to point to.
+ badPtr = uintptr(unsafe.Pointer(&b[len(b)-1])) + 1
+}
+
+var throttle = make(chan struct{}, 10)
+
+func noPointerArgs(a, b, c, d uintptr) {
+ sink = make([]byte, 4096)
+ <-throttle
+}
+
+func main() {
+ const N = 1000
+ for i := 0; i < N; i++ {
+ throttle <- struct{}{}
+ go noPointerArgs(badPtr, badPtr, badPtr, badPtr)
+ sink = make([]byte, 4096)
+ }
+}