diff options
| author | David du Colombier <0intro@gmail.com> | 2018-01-31 22:56:39 +0100 |
|---|---|---|
| committer | David du Colombier <0intro@gmail.com> | 2018-01-31 22:12:10 +0000 |
| commit | 6f37fee354e941c6f143b34014c269943962b116 (patch) | |
| tree | 960dc50974225b5792b4edd9db781d986545211d | |
| parent | e5186895fc7954c0992c345eb2a91f8c964b2099 (diff) | |
| download | go-6f37fee354e941c6f143b34014c269943962b116.tar.gz go-6f37fee354e941c6f143b34014c269943962b116.zip | |
cmd/go: fix TestNoCache on Plan 9
CL 91097 added TestNoCache. However, this
test is failing on Plan 9 because the HOME
environment variable doesn't contain the
home directory where the Go cache is located.
This change fixes the TestNoCache test
by using the home environment variable
instead of HOME on Plan 9.
Fixes #23644.
Change-Id: Icfb7a7a4c2852f159c93032b4081411628a2787f
Reviewed-on: https://go-review.googlesource.com/91216
Run-TryBot: David du Colombier <0intro@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
| -rw-r--r-- | src/cmd/go/go_test.go | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go index b2053f553c..ac47adb8e7 100644 --- a/src/cmd/go/go_test.go +++ b/src/cmd/go/go_test.go @@ -5387,7 +5387,11 @@ func TestNoCache(t *testing.T) { tg.parallel() tg.tempFile("triv.go", `package main; func main() {}`) tg.must(os.MkdirAll(tg.path("unwritable"), 0555)) - tg.setenv("HOME", tg.path(filepath.Join("unwritable", "home"))) + home := "HOME" + if runtime.GOOS == "plan9" { + home = "home" + } + tg.setenv(home, tg.path(filepath.Join("unwritable", "home"))) tg.unsetenv("GOCACHE") tg.run("build", "-o", tg.path("triv"), tg.path("triv.go")) tg.grepStderr("disabling cache", "did not disable cache") |