diff options
author | Cherry Zhang <cherryyz@google.com> | 2020-09-10 11:14:27 -0400 |
---|---|---|
committer | Cherry Zhang <cherryyz@google.com> | 2020-09-11 15:41:20 +0000 |
commit | 1ed4f12f4a6b9d783cf9a6fc3a292a433b8539c6 (patch) | |
tree | 0d2292755b7dd63c41fdf47e53b90810726b4fb8 | |
parent | ffd95aadcddc34ec2c83971346f04cf7234e0fca (diff) | |
download | go-1ed4f12f4a6b9d783cf9a6fc3a292a433b8539c6.tar.gz go-1ed4f12f4a6b9d783cf9a6fc3a292a433b8539c6.zip |
cmd/link: add a test to test RODATA is indeed read-only
Updates #38830.
Change-Id: Ie1f6ccef40a773f038aac587dfc26bf70a1a8536
Reviewed-on: https://go-review.googlesource.com/c/go/+/253921
Run-TryBot: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
-rw-r--r-- | src/cmd/link/link_test.go | 14 | ||||
-rw-r--r-- | src/cmd/link/testdata/testRO/x.go | 22 |
2 files changed, 36 insertions, 0 deletions
diff --git a/src/cmd/link/link_test.go b/src/cmd/link/link_test.go index 98798be465..4e60996d8e 100644 --- a/src/cmd/link/link_test.go +++ b/src/cmd/link/link_test.go @@ -800,3 +800,17 @@ func TestContentAddressableSymbols(t *testing.T) { t.Errorf("command %s failed: %v\n%s", cmd, err, out) } } + +func TestReadOnly(t *testing.T) { + // Test that read-only data is indeed read-only. + testenv.MustHaveGoBuild(t) + + t.Parallel() + + src := filepath.Join("testdata", "testRO", "x.go") + cmd := exec.Command(testenv.GoToolPath(t), "run", src) + out, err := cmd.CombinedOutput() + if err == nil { + t.Errorf("running test program did not fail. output:\n%s", out) + } +} diff --git a/src/cmd/link/testdata/testRO/x.go b/src/cmd/link/testdata/testRO/x.go new file mode 100644 index 0000000000..d77db6d563 --- /dev/null +++ b/src/cmd/link/testdata/testRO/x.go @@ -0,0 +1,22 @@ +// Copyright 2020 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// Test that read-only data is indeed read-only. This +// program attempts to modify read-only data, and it +// should fail. + +package main + +import "unsafe" + +var s = "hello" + +func main() { + println(s) + *(*struct { + p *byte + l int + })(unsafe.Pointer(&s)).p = 'H' + println(s) +} |