aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonathan Amsterdam <jba@google.com>2023-06-20 08:55:49 -0400
committerJonathan Amsterdam <jba@google.com>2023-06-20 23:57:50 +0000
commitf3bf18117b284b63f4350a5aa61773a30d91a6d5 (patch)
tree85d2d738553ee1633c326b703fcdb75361ac7263
parente122ebabb657021964f2bdd31e683ddfa023fd0c (diff)
downloadgo-f3bf18117b284b63f4350a5aa61773a30d91a6d5.tar.gz
go-f3bf18117b284b63f4350a5aa61773a30d91a6d5.zip
log/slog: fix HandlerOptions.ReplaceAttr doc
It said that Attrs with an empty key are ignored. In fact, zero Attrs are ignored. Fixes #60870. Change-Id: I221d3a25b0f0cc9001e06e9cc76bab29292c0741 Reviewed-on: https://go-review.googlesource.com/c/go/+/504535 Run-TryBot: Jonathan Amsterdam <jba@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
-rw-r--r--src/log/slog/handler.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/log/slog/handler.go b/src/log/slog/handler.go
index 8cd1e563eb..dc4c2d92bd 100644
--- a/src/log/slog/handler.go
+++ b/src/log/slog/handler.go
@@ -140,7 +140,7 @@ type HandlerOptions struct {
// ReplaceAttr is called to rewrite each non-group attribute before it is logged.
// The attribute's value has been resolved (see [Value.Resolve]).
- // If ReplaceAttr returns an Attr with Key == "", the attribute is discarded.
+ // If ReplaceAttr returns a zero Attr, the attribute is discarded.
//
// The built-in attributes with keys "time", "level", "source", and "msg"
// are passed to this function, except that time is omitted