diff options
| author | Bryan C. Mills <bcmills@google.com> | 2021-01-15 09:48:39 -0500 |
|---|---|---|
| committer | Bryan C. Mills <bcmills@google.com> | 2021-02-25 22:38:21 +0000 |
| commit | 5f15af111cb40c3ac154be88288abd381e6f61e2 (patch) | |
| tree | eb115e1b360c1577f69989424722125913d40849 | |
| parent | 9a7fe196e468c687ad7239b9447c584826331771 (diff) | |
| download | go-5f15af111cb40c3ac154be88288abd381e6f61e2.tar.gz go-5f15af111cb40c3ac154be88288abd381e6f61e2.zip | |
syscall: comment on fields omitted from the win32finddata1 struct
Updates #42637
Change-Id: I4c7d38034b60c2c04efdeb530a97d96deddfd6fe
Reviewed-on: https://go-review.googlesource.com/c/go/+/284152
Trust: Bryan C. Mills <bcmills@google.com>
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Trust: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
| -rw-r--r-- | src/syscall/types_windows.go | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/src/syscall/types_windows.go b/src/syscall/types_windows.go index 0349f3b180..5fef5c9477 100644 --- a/src/syscall/types_windows.go +++ b/src/syscall/types_windows.go @@ -398,6 +398,14 @@ type win32finddata1 struct { Reserved1 uint32 FileName [MAX_PATH]uint16 AlternateFileName [14]uint16 + + // The Microsoft documentation for this struct¹ describes three additional + // fields: dwFileType, dwCreatorType, and wFinderFlags. However, those fields + // are empirically only present in the macOS port of the Win32 API,² and thus + // not needed for binaries built for Windows. + // + // ¹ https://docs.microsoft.com/en-us/windows/win32/api/minwinbase/ns-minwinbase-win32_find_dataw + // ² https://golang.org/issue/42637#issuecomment-760715755 } func copyFindData(dst *Win32finddata, src *win32finddata1) { |