diff options
| author | David Chase <drchase@google.com> | 2017-01-10 08:29:34 -0500 |
|---|---|---|
| committer | David Chase <drchase@google.com> | 2017-01-10 17:29:46 +0000 |
| commit | d9a05791566aa8d54113ac88ae77b982872f9be7 (patch) | |
| tree | 2cf134c77ca7cc52ffe71acc629ea08699d68fcb | |
| parent | 2817e77024a53aae31cc02c01a26fce0ebb11a79 (diff) | |
| download | go-d9a05791566aa8d54113ac88ae77b982872f9be7.tar.gz go-d9a05791566aa8d54113ac88ae77b982872f9be7.zip | |
cmd/compile: disable flaky test
The test is inherently racy and vulnerable to starvation,
and within all.bash on some platforms that means it flakes.
Test is kept because it can be useful standalone to verify
behavior of GOEXPERIMENT=preeemptibleloops, and there is
likely to be further development of this feature in the
future.
There's also some question as to why it is flaking, because
though technically this is permitted, it's very odd in this
simple case.
Fixes #18589.
Change-Id: Ia0dd9037285c4a03122da4012c96981c9cc43b60
Reviewed-on: https://go-review.googlesource.com/35051
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
| -rw-r--r-- | test/fixedbugs/issue10958.go | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/test/fixedbugs/issue10958.go b/test/fixedbugs/issue10958.go index abbd64918a..86d2057622 100644 --- a/test/fixedbugs/issue10958.go +++ b/test/fixedbugs/issue10958.go @@ -1,12 +1,21 @@ -// +build !nacl -// buildrun -t 2 -gcflags=-d=ssa/insert_resched_checks/on,ssa/check/on +// +build !nacl,disabled +// buildrun -t 10 -gcflags=-d=ssa/insert_resched_checks/on,ssa/check/on // Copyright 2016 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. +// Test is disabled because it flakes when run in all.bash +// on some platforms, but is useful standalone to verify +// that rescheduling checks are working (and we may wish +// to investigate the flake, since it suggests that the +// loop rescheduling check may not work right on those +// platforms). + // This checks to see that call-free infinite loops do not -// block garbage collection. +// block garbage collection. IF YOU RUN IT STANDALONE without +// -gcflags=-d=ssa/insert_resched_checks/on in a not-experimental +// build, it should hang. package main |