diff options
| author | Michael Pratt <mpratt@google.com> | 2021-08-04 16:07:47 -0400 |
|---|---|---|
| committer | Michael Pratt <mpratt@google.com> | 2021-09-14 21:57:30 +0000 |
| commit | b2c04f0d48234765ce37bbb178bd174f3857929a (patch) | |
| tree | c335478c7965b18f542dcfc18a5554d78e7d08f7 | |
| parent | 181e8cde301cd8205489e746334174fee7290c9b (diff) | |
| download | go-b2c04f0d48234765ce37bbb178bd174f3857929a.tar.gz go-b2c04f0d48234765ce37bbb178bd174f3857929a.zip | |
runtime: avoid loop variable capture in test
In TestSegv, the t.Run closure captures the loop variable 'test'. Since
the subtest calls t.Parallel, the parent test is allowed to keep
running, changing the loop variable and thus changing the value of
'test' in the subtest.
Change-Id: I021ddc50304de08a341e6ffe486aa54e573d3b94
Reviewed-on: https://go-review.googlesource.com/c/go/+/339911
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
| -rw-r--r-- | src/runtime/crash_cgo_test.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go index 5729942cee..ce7bed920f 100644 --- a/src/runtime/crash_cgo_test.go +++ b/src/runtime/crash_cgo_test.go @@ -591,6 +591,7 @@ func TestSegv(t *testing.T) { } for _, test := range []string{"Segv", "SegvInCgo"} { + test := test t.Run(test, func(t *testing.T) { t.Parallel() got := runTestProg(t, "testprogcgo", test) |