diff options
author | Katie Hockman <katie@golang.org> | 2021-09-10 09:49:03 -0400 |
---|---|---|
committer | Katie Hockman <katie@golang.org> | 2021-09-10 15:20:38 +0000 |
commit | 213d9f9a3893eeed1fe1fe5e9e216da33f4d75c4 (patch) | |
tree | 55ba127da73a833507c39fa11f4bd98f7fc535ca | |
parent | 7c648e2acb31363ea128b754503343cf2c82ba6f (diff) | |
download | go-213d9f9a3893eeed1fe1fe5e9e216da33f4d75c4.tar.gz go-213d9f9a3893eeed1fe1fe5e9e216da33f4d75c4.zip |
[dev.fuzz] internal/fuzz: improve warning message when not instrumented
Change-Id: I005f66c965014b699de7e22750f417b28a32c03f
Reviewed-on: https://go-review.googlesource.com/c/go/+/349052
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
-rw-r--r-- | src/internal/fuzz/fuzz.go | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/internal/fuzz/fuzz.go b/src/internal/fuzz/fuzz.go index f36569b4cc..6c07da2dbe 100644 --- a/src/internal/fuzz/fuzz.go +++ b/src/internal/fuzz/fuzz.go @@ -613,11 +613,7 @@ func newCoordinator(opts CoordinateFuzzingOpts) (*coordinator, error) { covSize := len(coverage()) if covSize == 0 { - // TODO: improve this warning. This condition happens if the binary was - // built without fuzzing instrumtation (e.g., with 'go test -c'), so the - // warning may not be true. - fmt.Fprintf(c.opts.Log, "warning: coverage-guided fuzzing is not supported on this platform\n") - c.covOnlyInputs = 0 + fmt.Fprintf(c.opts.Log, "warning: the test binary was not built with coverage instrumentation, so fuzzing will run without coverage guidance and may be inefficient\n") } else { // Set c.coverageData to a clean []byte full of zeros. c.coverageMask = make([]byte, covSize) |