diff options
| author | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2021-03-04 14:40:50 +0700 |
|---|---|---|
| committer | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2021-03-05 18:46:16 +0000 |
| commit | 80098ef00c1c8a832b2d67d7cbd4dea5f8eff6e9 (patch) | |
| tree | 72893010f480b844d0c0074b2cb8208161027fcc | |
| parent | 70b277cf2e953bb9994b00898280f4659a47471e (diff) | |
| download | go-80098ef00c1c8a832b2d67d7cbd4dea5f8eff6e9.tar.gz go-80098ef00c1c8a832b2d67d7cbd4dea5f8eff6e9.zip | |
cmd/compile: don't expand invalid embedded interface
The invalid interface type will be reported already, so don't expand
that invalid one, which causes the compiler crashes.
Updates #43311
Change-Id: Ic335cfa74f0b9fcfd0929dc5fd31d9156a8f5f5c
Reviewed-on: https://go-review.googlesource.com/c/go/+/298710
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
| -rw-r--r-- | src/cmd/compile/internal/types/size.go | 2 | ||||
| -rw-r--r-- | test/fixedbugs/issue20245.go | 2 | ||||
| -rw-r--r-- | test/fixedbugs/issue22921.go | 2 | ||||
| -rw-r--r-- | test/fixedbugs/issue27938.go | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/src/cmd/compile/internal/types/size.go b/src/cmd/compile/internal/types/size.go index 4c7378560c..ef23cdf5fe 100644 --- a/src/cmd/compile/internal/types/size.go +++ b/src/cmd/compile/internal/types/size.go @@ -100,7 +100,7 @@ func expandiface(t *Type) { } for _, m := range t.Methods().Slice() { - if m.Sym != nil { + if m.Sym != nil || m.Type == nil { continue } diff --git a/test/fixedbugs/issue20245.go b/test/fixedbugs/issue20245.go index b07dbe20de..20258231d1 100644 --- a/test/fixedbugs/issue20245.go +++ b/test/fixedbugs/issue20245.go @@ -1,4 +1,4 @@ -// errorcheck +// errorcheck -d=panic // Copyright 2017 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style diff --git a/test/fixedbugs/issue22921.go b/test/fixedbugs/issue22921.go index 5336ba3410..cdd77fb24f 100644 --- a/test/fixedbugs/issue22921.go +++ b/test/fixedbugs/issue22921.go @@ -1,4 +1,4 @@ -// errorcheck +// errorcheck -d=panic // Copyright 2020 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style diff --git a/test/fixedbugs/issue27938.go b/test/fixedbugs/issue27938.go index ed974e642d..2589e1eff8 100644 --- a/test/fixedbugs/issue27938.go +++ b/test/fixedbugs/issue27938.go @@ -1,4 +1,4 @@ -// errorcheck +// errorcheck -d=panic // Copyright 2018 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style |