diff options
| author | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2021-04-21 15:42:05 +0700 |
|---|---|---|
| committer | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2021-04-21 09:07:09 +0000 |
| commit | 5f1df260a91183c605c08af7b00741d2761b84e4 (patch) | |
| tree | a1ab7e7f2c44463c0f99da11768e7f81a882e4c1 | |
| parent | 7735ec96c17f0aa8b27c64d82115755e29214164 (diff) | |
| download | go-5f1df260a91183c605c08af7b00741d2761b84e4.tar.gz go-5f1df260a91183c605c08af7b00741d2761b84e4.zip | |
cmd/compile: allow export/import OSLICE2ARRPTR
Updates #395
Fixes #45665
Change-Id: Iaf053c0439a573e9193d40942fbdb22ac3b4d3bb
Reviewed-on: https://go-review.googlesource.com/c/go/+/312070
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
| -rw-r--r-- | src/cmd/compile/internal/typecheck/iexport.go | 2 | ||||
| -rw-r--r-- | src/cmd/compile/internal/typecheck/iimport.go | 2 | ||||
| -rw-r--r-- | test/fixedbugs/issue45665.go | 15 |
3 files changed, 17 insertions, 2 deletions
diff --git a/src/cmd/compile/internal/typecheck/iexport.go b/src/cmd/compile/internal/typecheck/iexport.go index 6a56abb1b9..5955b3d358 100644 --- a/src/cmd/compile/internal/typecheck/iexport.go +++ b/src/cmd/compile/internal/typecheck/iexport.go @@ -1677,7 +1677,7 @@ func (w *exportWriter) expr(n ir.Node) { w.op(ir.OEND) } - case ir.OCONV, ir.OCONVIFACE, ir.OCONVNOP, ir.OBYTES2STR, ir.ORUNES2STR, ir.OSTR2BYTES, ir.OSTR2RUNES, ir.ORUNESTR: + case ir.OCONV, ir.OCONVIFACE, ir.OCONVNOP, ir.OBYTES2STR, ir.ORUNES2STR, ir.OSTR2BYTES, ir.OSTR2RUNES, ir.ORUNESTR, ir.OSLICE2ARRPTR: n := n.(*ir.ConvExpr) if go117ExportTypes { w.op(n.Op()) diff --git a/src/cmd/compile/internal/typecheck/iimport.go b/src/cmd/compile/internal/typecheck/iimport.go index 8c197215d7..642abe61ba 100644 --- a/src/cmd/compile/internal/typecheck/iimport.go +++ b/src/cmd/compile/internal/typecheck/iimport.go @@ -1262,7 +1262,7 @@ func (r *importReader) node() ir.Node { } return n - case ir.OCONV, ir.OCONVIFACE, ir.OCONVNOP, ir.OBYTES2STR, ir.ORUNES2STR, ir.OSTR2BYTES, ir.OSTR2RUNES, ir.ORUNESTR: + case ir.OCONV, ir.OCONVIFACE, ir.OCONVNOP, ir.OBYTES2STR, ir.ORUNES2STR, ir.OSTR2BYTES, ir.OSTR2RUNES, ir.ORUNESTR, ir.OSLICE2ARRPTR: if !go117ExportTypes && op != ir.OCONV { // unreachable - mapped to OCONV case by exporter goto error diff --git a/test/fixedbugs/issue45665.go b/test/fixedbugs/issue45665.go new file mode 100644 index 0000000000..2981a4904c --- /dev/null +++ b/test/fixedbugs/issue45665.go @@ -0,0 +1,15 @@ +// compile + +// Copyright 2021 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package main + +func main() { + Get([]string{"a", "b"}) +} + +func Get(ss []string) *[2]string { + return (*[2]string)(ss) +} |