diff options
| author | Alessandro Arzilli <alessandro.arzilli@gmail.com> | 2020-11-12 14:58:46 +0100 |
|---|---|---|
| committer | Dmitri Shuralyov <dmitshur@golang.org> | 2020-11-23 19:42:26 +0000 |
| commit | 16ddb8bc763c33fb172d0c1bcd04d070f36f9cc8 (patch) | |
| tree | 9f9e2f163f9b2d38be97b85b009f43fd1d23edd7 | |
| parent | 20f50bba49e6338793a5711dc1c6ed60e4b10df8 (diff) | |
| download | go-16ddb8bc763c33fb172d0c1bcd04d070f36f9cc8.tar.gz go-16ddb8bc763c33fb172d0c1bcd04d070f36f9cc8.zip | |
[release-branch.go1.15] cmd/compile: do not emit an extra debug_line entry for the end of seq addr
Uses DW_LNS_advance_pc directly, instead of calling putpclcdelta
because the latter will create a new debug_line entry for the end of
sequence address.
Updates #42484.
Fixes #42521.
Change-Id: Ib6355605cac101b9bf37a3b4961ab0cee678a839
Reviewed-on: https://go-review.googlesource.com/c/go/+/268937
Trust: Than McIntosh <thanm@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/269517
| -rw-r--r-- | src/cmd/internal/obj/dwarf.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/cmd/internal/obj/dwarf.go b/src/cmd/internal/obj/dwarf.go index cd1d5b86878..8a12849d772 100644 --- a/src/cmd/internal/obj/dwarf.go +++ b/src/cmd/internal/obj/dwarf.go @@ -106,7 +106,8 @@ func (ctxt *Link) generateDebugLinesSymbol(s, lines *LSym) { // GDB will assign a line number of zero the last row in the line // table, which we don't want. lastlen := uint64(s.Size - (lastpc - s.Func.Text.Pc)) - putpclcdelta(ctxt, dctxt, lines, lastlen, 0) + dctxt.AddUint8(lines, dwarf.DW_LNS_advance_pc) + dwarf.Uleb128put(dctxt, lines, int64(lastlen)) dctxt.AddUint8(lines, 0) // start extended opcode dwarf.Uleb128put(dctxt, lines, 1) dctxt.AddUint8(lines, dwarf.DW_LNE_end_sequence) |