diff options
| author | Ian Lance Taylor <iant@golang.org> | 2019-01-11 14:26:24 -0800 |
|---|---|---|
| committer | Filippo Valsorda <valsorda@google.com> | 2019-01-23 19:06:01 +0000 |
| commit | daef79d40510df2708dba127bb0721fb8548bc9e (patch) | |
| tree | d7ab9f7800f56ac3e9efa58e6f9ece0d5b6470ec | |
| parent | 983d8092ef8cc5c92c5a598baf1b7a5dbfd51ef4 (diff) | |
| download | go-daef79d40510df2708dba127bb0721fb8548bc9e.tar.gz go-daef79d40510df2708dba127bb0721fb8548bc9e.zip | |
[release-branch.go1.11-security] net: pass if at least one matching entry in TestLookupGmailTXT
Fixes #29698
Change-Id: I0531c0a274b120af8871aa2f5975744ff6c912a3
Reviewed-on: https://go-review.googlesource.com/c/157638
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-on: https://team-review.git.corp.google.com/c/401203
Reviewed-by: Filippo Valsorda <valsorda@google.com>
| -rw-r--r-- | src/net/lookup_test.go | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/net/lookup_test.go b/src/net/lookup_test.go index 5c66dfa260..f2adbc18c5 100644 --- a/src/net/lookup_test.go +++ b/src/net/lookup_test.go @@ -237,11 +237,16 @@ func TestLookupGmailTXT(t *testing.T) { if len(txts) == 0 { t.Error("got no record") } + found := false for _, txt := range txts { - if !strings.Contains(txt, tt.txt) || (!strings.HasSuffix(txt, tt.host) && !strings.HasSuffix(txt, tt.host+".")) { - t.Errorf("got %s; want a record containing %s, %s", txt, tt.txt, tt.host) + if strings.Contains(txt, tt.txt) && (strings.HasSuffix(txt, tt.host) || strings.HasSuffix(txt, tt.host+".")) { + found = true + break } } + if !found { + t.Errorf("got %v; want a record containing %s, %s", txts, tt.txt, tt.host) + } } } |