diff options
author | Filippo Valsorda <filippo@golang.org> | 2019-01-23 19:11:09 -0500 |
---|---|---|
committer | Filippo Valsorda <filippo@golang.org> | 2019-01-23 19:11:09 -0500 |
commit | 3fb9dafacc45817296885a6e877ba7a5f1c199a4 (patch) | |
tree | e3ac4198500e57de42c27354c98f5aced495b590 | |
parent | 572c4bce6792d169d467aad26781fa8cab52f8d6 (diff) | |
parent | 35bb62e60a7779ff82c3067903b3306ff8666471 (diff) | |
download | go-3fb9dafacc45817296885a6e877ba7a5f1c199a4.tar.gz go-3fb9dafacc45817296885a6e877ba7a5f1c199a4.zip |
[dev.boringcrypto.go1.11] all: merge go1.11.5 into dev.boringcrypto.go1.11
Change-Id: I798d95666c47746412a28c458a4cda0f0a9d79c6
-rw-r--r-- | doc/devel/release.html | 14 | ||||
-rw-r--r-- | src/crypto/elliptic/elliptic.go | 3 | ||||
-rw-r--r-- | src/net/lookup_test.go | 9 |
3 files changed, 23 insertions, 3 deletions
diff --git a/doc/devel/release.html b/doc/devel/release.html index 73f7a0e304..226148e93b 100644 --- a/doc/devel/release.html +++ b/doc/devel/release.html @@ -66,6 +66,13 @@ See the <a href="https://github.com/golang/go/issues?q=milestone%3AGo1.11.4+labe 1.11.4 milestone</a> on our issue tracker for details. </p> +<p> +go1.11.5 (released 2019/01/23) includes a security fix to the +<code>crypto/elliptic</code> package. +See the <a href="https://github.com/golang/go/issues?q=milestone%3AGo1.11.5+label%3ACherryPickApproved">Go +1.11.5 milestone</a> on our issue tracker for details. +</p> + <h2 id="go1.10">go1.10 (released 2018/02/16)</h2> <p> @@ -131,6 +138,13 @@ See the <a href="https://github.com/golang/go/issues?q=milestone%3AGo1.10.7+labe Go 1.10.7 milestone</a> on our issue tracker for details. </p> +<p> +go1.10.8 (released 2019/01/23) includes a security fix to the +<code>crypto/elliptic</code> package. +See the <a href="https://github.com/golang/go/issues?q=milestone%3AGo1.10.8+label%3ACherryPickApproved">Go +1.10.8 milestone</a> on our issue tracker for details. +</p> + <h2 id="go1.9">go1.9 (released 2017/08/24)</h2> <p> diff --git a/src/crypto/elliptic/elliptic.go b/src/crypto/elliptic/elliptic.go index 4fc2b5e521..c84657c5e3 100644 --- a/src/crypto/elliptic/elliptic.go +++ b/src/crypto/elliptic/elliptic.go @@ -210,8 +210,9 @@ func (curve *CurveParams) doubleJacobian(x, y, z *big.Int) (*big.Int, *big.Int, x3 := new(big.Int).Mul(alpha, alpha) beta8 := new(big.Int).Lsh(beta, 3) + beta8.Mod(beta8, curve.P) x3.Sub(x3, beta8) - for x3.Sign() == -1 { + if x3.Sign() == -1 { x3.Add(x3, curve.P) } x3.Mod(x3, curve.P) diff --git a/src/net/lookup_test.go b/src/net/lookup_test.go index 5c66dfa260..f2adbc18c5 100644 --- a/src/net/lookup_test.go +++ b/src/net/lookup_test.go @@ -237,11 +237,16 @@ func TestLookupGmailTXT(t *testing.T) { if len(txts) == 0 { t.Error("got no record") } + found := false for _, txt := range txts { - if !strings.Contains(txt, tt.txt) || (!strings.HasSuffix(txt, tt.host) && !strings.HasSuffix(txt, tt.host+".")) { - t.Errorf("got %s; want a record containing %s, %s", txt, tt.txt, tt.host) + if strings.Contains(txt, tt.txt) && (strings.HasSuffix(txt, tt.host) || strings.HasSuffix(txt, tt.host+".")) { + found = true + break } } + if !found { + t.Errorf("got %v; want a record containing %s, %s", txts, tt.txt, tt.host) + } } } |