diff options
| author | Bryan C. Mills <bcmills@google.com> | 2021-12-02 09:39:22 -0500 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-04-22 00:37:23 +0000 |
| commit | bf19163a545c3117ab3c309a691f32a42cf29efd (patch) | |
| tree | 2ba13131595ac7679d7a94b02b5e2ff2b5a882ed | |
| parent | c9031a44b2cf734e6d1f64c31d6ee3a34ca1a9cc (diff) | |
| download | go-bf19163a545c3117ab3c309a691f32a42cf29efd.tar.gz go-bf19163a545c3117ab3c309a691f32a42cf29efd.zip | |
runtime/cgo: remove stdlib.h warning workaround on darwin
CL 205457 added the flag -Wno-nullability-completeness to work
around a user-reported build breakage on macOS Catalina.
However, according to
https://golang.org/issue/35247#issuecomment-589115489 the root cause
of the breakage may be a toolchain misconfiguration on the host
(perhaps compiling the XCode stdlib using a Homebrew build of the
"clang" compiler?).
Adding an obscure warning flag to enable building stdlib.h with an
otherwise-broken toolchain seems clearly inappropriate to me.
If need be we can instead provide guidance to users on how to unbreak
their toolchain.
Updates #35247
Fixes #49913
Change-Id: I84def34e101bed7911d8d78a991a29095b8791fa
Reviewed-on: https://go-review.googlesource.com/c/go/+/368634
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
| -rw-r--r-- | src/runtime/cgo/cgo.go | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/runtime/cgo/cgo.go b/src/runtime/cgo/cgo.go index 4d2caf6c4f..8d72d792b1 100644 --- a/src/runtime/cgo/cgo.go +++ b/src/runtime/cgo/cgo.go @@ -23,9 +23,6 @@ package cgo #cgo solaris LDFLAGS: -lxnet #cgo illumos LDFLAGS: -lsocket -// Issue 35247. -#cgo darwin CFLAGS: -Wno-nullability-completeness - #cgo CFLAGS: -Wall -Werror #cgo solaris CPPFLAGS: -D_POSIX_PTHREAD_SEMANTICS |