diff options
| author | Keith Randall <khr@golang.org> | 2022-04-26 16:32:07 -0700 |
|---|---|---|
| committer | Keith Randall <khr@google.com> | 2022-04-27 00:09:45 +0000 |
| commit | 68b655f2b91c4407ccd781271039857e0d332989 (patch) | |
| tree | 8d67b3607c8dccba9d829c62c599941f1201632a | |
| parent | d29f5247b8cbf5f2cb7b0e325a5eb1c7c5c1a91f (diff) | |
| download | go-68b655f2b91c4407ccd781271039857e0d332989.tar.gz go-68b655f2b91c4407ccd781271039857e0d332989.zip | |
runtime: disable windowed Smhasher test on 32-bit systems
This test tends to be flaky on 32-bit systems.
There's not enough bits in the hash output, so we
expect a nontrivial number of collisions, and it is
often quite a bit higher than expected.
Fixes #43130
Change-Id: If35413b7c45eed778a08b834dacf98009ceca840
Reviewed-on: https://go-review.googlesource.com/c/go/+/402456
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Keith Randall <khr@google.com>
| -rw-r--r-- | src/runtime/hash_test.go | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/runtime/hash_test.go b/src/runtime/hash_test.go index cf56c57a5f..e72600641f 100644 --- a/src/runtime/hash_test.go +++ b/src/runtime/hash_test.go @@ -525,6 +525,13 @@ func windowed(t *testing.T, k Key) { if GOARCH == "wasm" { t.Skip("Too slow on wasm") } + if PtrSize == 4 { + // This test tends to be flaky on 32-bit systems. + // There's not enough bits in the hash output, so we + // expect a nontrivial number of collisions, and it is + // often quite a bit higher than expected. See issue 43130. + t.Skip("Flaky on 32-bit systems") + } if testing.Short() { t.Skip("Skipping in short mode") } |