Add comments about "unaccompanied" use of Relay{Usage,Exclusion}

When used outside of RelaySelector, these two types don't enforce
one another's presence, and as such have a bit more risk of
negligent use.

2 files changed, 4 insertions, 0 deletions

diff --git a/crates/tor-circmgr/src/hspool.rs b/crates/tor-circmgr/src/hspool.rs
index ff0fe7af7..f14ccf3f4 100644
--- a/crates/tor-circmgr/src/hspool.rs
+++ b/crates/tor-circmgr/src/hspool.rs
@@ -270,6 +270,8 @@ impl<R: Runtime> HsCircPool<R> {
             let path_cfg = self.circmgr.builder().path_config();
             let cfg = path_cfg.relay_selection_config();
             match avoid_target {
+                // TODO #504: This is an unaccompanied RelayExclusion, and is therefore a
+                // bit suspect.  We should consider whether we like this behavior.
                 Some(ct) => RelayExclusion::exclude_channel_target_family(&cfg, ct, netdir),
                 None => RelayExclusion::no_relays_excluded(),
             }
diff --git a/crates/tor-guardmgr/src/filter.rs b/crates/tor-guardmgr/src/filter.rs
index 378c9f076..acdec2dc5 100644
--- a/crates/tor-guardmgr/src/filter.rs
+++ b/crates/tor-guardmgr/src/filter.rs
@@ -81,6 +81,8 @@ impl GuardFilter {
         use tor_netdir::{RelayWeight, WeightRole};
         let mut guard_bw: RelayWeight = 0.into();
         let mut permitted_bw: RelayWeight = 0.into();
+        // TODO #504: This is an unaccompanied RelayUsage, and is therefore a
+        // bit suspect.  We should consider whether we like this behavior.
         let usage = RelayUsage::new_guard();
 
         // TODO: There is a case to be made for converting "permitted by this