aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGabriela Moldovan <gabi@torproject.org>2024-01-11 19:23:29 +0000
committerGabriela Moldovan <gabi@torproject.org>2024-01-11 19:25:52 +0000
commita1e053cef90b1b4f63ea7980bdb449bba3ef0120 (patch)
tree92d30e6a6d54a94d30fef069406f65e09688e9a1
parent14f9cbc1f2a39f236672f5e8f71674317b153bad (diff)
downloadarti-a1e053cef90b1b4f63ea7980bdb449bba3ef0120.tar.gz
arti-a1e053cef90b1b4f63ea7980bdb449bba3ef0120.zip
tor-netdoc: Turn a TODO HSS into #1221.
-rw-r--r--crates/tor-netdoc/src/doc/hsdesc/build/inner.rs3
1 files changed, 2 insertions, 1 deletions
diff --git a/crates/tor-netdoc/src/doc/hsdesc/build/inner.rs b/crates/tor-netdoc/src/doc/hsdesc/build/inner.rs
index 2beb76a6f..3a029393b 100644
--- a/crates/tor-netdoc/src/doc/hsdesc/build/inner.rs
+++ b/crates/tor-netdoc/src/doc/hsdesc/build/inner.rs
@@ -145,7 +145,8 @@ impl<'a> NetdocBuilder for HsDescInner<'a> {
// The subject key is the the ed25519 equivalent of the svc_ntor_key curve25519 public
// encryption key.
- // TODO hss: should the sign bit be 0 or 1?
+ // TODO (#1221): this is wrong. The sign bit should be computed according to appendix A
+ // from propo 228.
let signbit = 0;
let ed_svc_ntor_key =
convert_curve25519_to_ed25519_public(&intro_point.svc_ntor_key, signbit)