aboutsummaryrefslogtreecommitdiff
path: root/alacritty_terminal/src/tty/windows/conpty.rs
diff options
context:
space:
mode:
Diffstat (limited to 'alacritty_terminal/src/tty/windows/conpty.rs')
-rw-r--r--alacritty_terminal/src/tty/windows/conpty.rs4
1 files changed, 4 insertions, 0 deletions
diff --git a/alacritty_terminal/src/tty/windows/conpty.rs b/alacritty_terminal/src/tty/windows/conpty.rs
index 31f4c252..a1c7edfd 100644
--- a/alacritty_terminal/src/tty/windows/conpty.rs
+++ b/alacritty_terminal/src/tty/windows/conpty.rs
@@ -90,6 +90,10 @@ pub type ConptyHandle = Arc<Conpty>;
impl Drop for Conpty {
fn drop(&mut self) {
+ // XXX: This will block until the conout pipe is drained. Will cause a deadlock if the
+ // conout pipe has already been dropped by this point.
+ //
+ // See PR #3084 and https://docs.microsoft.com/en-us/windows/console/closepseudoconsole
unsafe { (self.api.ClosePseudoConsole)(self.handle) }
}
}