diff options
author | Christian Duerr <chrisduerr@users.noreply.github.com> | 2018-12-17 19:06:07 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-12-17 19:06:07 +0000 |
commit | cf9d94eb1256881d48b1a3dc63db6caf32bfb841 (patch) | |
tree | daae5794b13ba42cdfe57b431eedd76aa8a12b49 /src | |
parent | 0c3e28617a95b4ca30ad9bdbb9114f1e4d41dce5 (diff) | |
download | alacritty-cf9d94eb1256881d48b1a3dc63db6caf32bfb841.tar.gz alacritty-cf9d94eb1256881d48b1a3dc63db6caf32bfb841.zip |
Add color option to visual bell
This adds the option to specify the color of the visual bell using the
`visual_bell.color` configuration setting.
This is done by rendering a big quad over the entire screen, which also
opens up options to draw other arbitrary rectangles on the screen in the
future.
Diffstat (limited to 'src')
-rw-r--r-- | src/config.rs | 24 | ||||
-rw-r--r-- | src/display.rs | 22 | ||||
-rw-r--r-- | src/renderer/mod.rs | 417 |
3 files changed, 328 insertions, 135 deletions
diff --git a/src/config.rs b/src/config.rs index 39a5c024..d5eadcf8 100644 --- a/src/config.rs +++ b/src/config.rs @@ -157,13 +157,12 @@ pub struct VisualBellConfig { animation: VisualBellAnimation, /// Visual bell duration in milliseconds - #[serde(deserialize_with = "deserialize_visual_bell_duration")] - #[serde(default="default_visual_bell_duration")] + #[serde(default, deserialize_with = "deserialize_visual_bell_duration")] duration: u16, -} -fn default_visual_bell_duration() -> u16 { - 150 + /// Visual bell flash color + #[serde(default="default_visual_bell_color", deserialize_with = "rgb_from_hex")] + color: Rgb, } fn deserialize_visual_bell_duration<'a, D>(deserializer: D) -> ::std::result::Result<u16, D::Error> @@ -173,11 +172,15 @@ fn deserialize_visual_bell_duration<'a, D>(deserializer: D) -> ::std::result::Re Ok(duration) => Ok(duration), Err(err) => { error!("problem with config: {}; Using default value", err); - Ok(default_visual_bell_duration()) + Ok(0) }, } } +fn default_visual_bell_color() -> Rgb { + Rgb { r: 255, g: 255, b: 255 } +} + impl VisualBellConfig { /// Visual bell animation #[inline] @@ -190,13 +193,20 @@ impl VisualBellConfig { pub fn duration(&self) -> Duration { Duration::from_millis(u64::from(self.duration)) } + + /// Visual bell flash color + #[inline] + pub fn color(&self) -> Rgb { + self.color + } } impl Default for VisualBellConfig { fn default() -> VisualBellConfig { VisualBellConfig { animation: VisualBellAnimation::default(), - duration: default_visual_bell_duration(), + color: default_visual_bell_color(), + duration: 0, } } } diff --git a/src/display.rs b/src/display.rs index 99889c67..120cd1dc 100644 --- a/src/display.rs +++ b/src/display.rs @@ -158,8 +158,8 @@ impl Display { let dimensions = options.dimensions() .unwrap_or_else(|| config.dimensions()); - let mut padding_x = (f64::from(config.padding().x) * dpr).floor(); - let mut padding_y = (f64::from(config.padding().y) * dpr).floor(); + let mut padding_x = f64::from(config.padding().x) * dpr; + let mut padding_y = f64::from(config.padding().y) * dpr; if dimensions.columns_u32() > 0 && dimensions.lines_u32() > 0 @@ -168,6 +168,8 @@ impl Display { // Calculate new size based on cols/lines specified in config let width = cell_width as u32 * dimensions.columns_u32(); let height = cell_height as u32 * dimensions.lines_u32(); + padding_x = padding_x.floor(); + padding_y = padding_y.floor(); viewport_size = PhysicalSize::new( f64::from(width) + 2. * padding_x, @@ -211,7 +213,6 @@ impl Display { renderer.with_api( config, &size_info, - 0., /* visual bell intensity */ |api| { api.clear(background_color); }, @@ -325,8 +326,6 @@ impl Display { self.update_glyph_cache(config); } - // Receive any resize events; only call gl::Viewport on last - // available if let Some(psize) = new_size.take() { let width = psize.width as f32; let height = psize.height as f32; @@ -405,7 +404,7 @@ impl Display { // handling and rendering. drop(terminal); - self.renderer.with_api(config, &size_info, visual_bell_intensity, |api| { + self.renderer.with_api(config, &size_info, |api| { api.clear(background_color); }); @@ -416,12 +415,15 @@ impl Display { { let _sampler = self.meter.sampler(); - self.renderer.with_api(config, &size_info, visual_bell_intensity, |mut api| { + self.renderer.with_api(config, &size_info, |mut api| { // Draw the grid api.render_cells(grid_cells.iter(), glyph_cache); }); } + // Draw rectangles + self.renderer.draw_rects(config, &size_info, visual_bell_intensity); + // Draw render timer if self.render_timer { let timing = format!("{:.3} usec", self.meter.average()); @@ -430,7 +432,7 @@ impl Display { g: 0x4e, b: 0x53, }; - self.renderer.with_api(config, &size_info, visual_bell_intensity, |mut api| { + self.renderer.with_api(config, &size_info, |mut api| { api.render_string(&timing[..], size_info.lines() - 2, glyph_cache, color); }); } @@ -446,7 +448,7 @@ impl Display { g: 0x00, b: 0x00, }; - self.renderer.with_api(config, &size_info, visual_bell_intensity, |mut api| { + self.renderer.with_api(config, &size_info, |mut api| { api.render_string(&msg, size_info.lines() - 1, glyph_cache, color); }); } else if self.logger_proxy.warnings() { @@ -459,7 +461,7 @@ impl Display { g: 0xff, b: 0x00, }; - self.renderer.with_api(config, &size_info, visual_bell_intensity, |mut api| { + self.renderer.with_api(config, &size_info, |mut api| { api.render_string(&msg, size_info.lines() - 1, glyph_cache, color); }); } diff --git a/src/renderer/mod.rs b/src/renderer/mod.rs index 5d7a661f..c05301cc 100644 --- a/src/renderer/mod.rs +++ b/src/renderer/mod.rs @@ -37,12 +37,18 @@ use glutin::dpi::PhysicalSize; // Shader paths for live reload static TEXT_SHADER_F_PATH: &'static str = concat!(env!("CARGO_MANIFEST_DIR"), "/res/text.f.glsl"); static TEXT_SHADER_V_PATH: &'static str = concat!(env!("CARGO_MANIFEST_DIR"), "/res/text.v.glsl"); +static RECT_SHADER_F_PATH: &'static str = concat!(env!("CARGO_MANIFEST_DIR"), "/res/rect.f.glsl"); +static RECT_SHADER_V_PATH: &'static str = concat!(env!("CARGO_MANIFEST_DIR"), "/res/rect.v.glsl"); // Shader source which is used when live-shader-reload feature is disable static TEXT_SHADER_F: &'static str = include_str!(concat!(env!("CARGO_MANIFEST_DIR"), "/res/text.f.glsl")); static TEXT_SHADER_V: &'static str = include_str!(concat!(env!("CARGO_MANIFEST_DIR"), "/res/text.v.glsl")); +static RECT_SHADER_F: &'static str = + include_str!(concat!(env!("CARGO_MANIFEST_DIR"), "/res/rect.f.glsl")); +static RECT_SHADER_V: &'static str = + include_str!(concat!(env!("CARGO_MANIFEST_DIR"), "/res/rect.v.glsl")); /// `LoadGlyph` allows for copying a rasterized glyph into graphics memory pub trait LoadGlyph { @@ -98,7 +104,7 @@ impl From<ShaderCreationError> for Error { /// /// Uniforms are prefixed with "u", and vertex attributes are prefixed with "a". #[derive(Debug)] -pub struct ShaderProgram { +pub struct TextShaderProgram { // Program id id: GLuint, @@ -111,15 +117,23 @@ pub struct ShaderProgram { /// Cell dimensions (pixels) u_cell_dim: GLint, - /// Visual bell - u_visual_bell: GLint, - /// Background pass flag /// /// Rendering is split into two passes; 1 for backgrounds, and one for text u_background: GLint, } +/// Rectangle drawing program +/// +/// Uniforms are prefixed with "u" +#[derive(Debug)] +pub struct RectShaderProgram { + // Program id + id: GLuint, + /// Rectangle color + u_col: GLint, +} + #[derive(Copy, Debug, Clone)] pub struct Glyph { tex_id: GLuint, @@ -351,11 +365,13 @@ struct InstanceData { #[derive(Debug)] pub struct QuadRenderer { - program: ShaderProgram, + program: TextShaderProgram, + rect_program: RectShaderProgram, vao: GLuint, - vbo: GLuint, ebo: GLuint, vbo_instance: GLuint, + rect_vao: GLuint, + rect_vbo: GLuint, atlas: Vec<Atlas>, current_atlas: usize, active_tex: GLuint, @@ -369,9 +385,8 @@ pub struct RenderApi<'a> { batch: &'a mut Batch, atlas: &'a mut Vec<Atlas>, current_atlas: &'a mut usize, - program: &'a mut ShaderProgram, + program: &'a mut TextShaderProgram, config: &'a Config, - visual_bell_intensity: f32, } #[derive(Debug)] @@ -470,7 +485,8 @@ const ATLAS_SIZE: i32 = 1024; impl QuadRenderer { // TODO should probably hand this a transform instead of width/height pub fn new(size: PhysicalSize) -> Result<QuadRenderer, Error> { - let program = ShaderProgram::new(size)?; + let program = TextShaderProgram::new(size)?; + let rect_program = RectShaderProgram::new()?; let mut vao: GLuint = 0; let mut vbo: GLuint = 0; @@ -478,6 +494,10 @@ impl QuadRenderer { let mut vbo_instance: GLuint = 0; + let mut rect_vao: GLuint = 0; + let mut rect_vbo: GLuint = 0; + let mut rect_ebo: GLuint = 0; + unsafe { gl::Enable(gl::BLEND); gl::BlendFunc(gl::SRC1_COLOR, gl::ONE_MINUS_SRC1_COLOR); @@ -598,8 +618,27 @@ impl QuadRenderer { gl::EnableVertexAttribArray(5); gl::VertexAttribDivisor(5, 1); + // Rectangle setup + gl::GenVertexArrays(1, &mut rect_vao); + gl::GenBuffers(1, &mut rect_vbo); + gl::GenBuffers(1, &mut rect_ebo); + gl::BindVertexArray(rect_vao); + let indices: [i32; 6] = [ + 0, 1, 3, + 1, 2, 3, + ]; + gl::BindBuffer(gl::ELEMENT_ARRAY_BUFFER, rect_ebo); + gl::BufferData( + gl::ELEMENT_ARRAY_BUFFER, + (size_of::<i32>() * indices.len()) as _, + indices.as_ptr() as *const _, + gl::STATIC_DRAW + ); + + // Cleanup gl::BindVertexArray(0); gl::BindBuffer(gl::ARRAY_BUFFER, 0); + gl::BindBuffer(gl::ELEMENT_ARRAY_BUFFER, 0); } let (msg_tx, msg_rx) = mpsc::channel(); @@ -635,10 +674,12 @@ impl QuadRenderer { let mut renderer = QuadRenderer { program, + rect_program, vao, - vbo, ebo, vbo_instance, + rect_vao, + rect_vbo, atlas: Vec::new(), current_atlas: 0, active_tex: 0, @@ -652,28 +693,77 @@ impl QuadRenderer { Ok(renderer) } - pub fn with_api<F, T>( + // Draw all rectangles simultaneously to prevent excessive program swaps + pub fn draw_rects( &mut self, config: &Config, props: &term::SizeInfo, visual_bell_intensity: f64, + ) { + // Swap to rectangle rendering program + unsafe { + // Swap program + gl::UseProgram(self.rect_program.id); + + // Remove padding from viewport + gl::Viewport(0, 0, props.width as i32, props.height as i32); + + // Change blending strategy + gl::BlendFunc(gl::SRC_ALPHA, gl::ONE_MINUS_SRC_ALPHA); + + // Setup data and buffers + gl::BindVertexArray(self.rect_vao); + gl::BindBuffer(gl::ARRAY_BUFFER, self.rect_vbo); + + // Position + gl::VertexAttribPointer(0, 3, gl::FLOAT, gl::FALSE, (size_of::<f32>() * 3) as _, ptr::null()); + gl::EnableVertexAttribArray(0); + } + + // Draw visual bell + let color = config.visual_bell().color(); + let rect = Rect::new(0., 0., props.width, props.height); + self.render_rect(&rect, color, visual_bell_intensity as f32, props); + + // Deactivate rectangle program again + unsafe { + // Reset blending strategy + gl::BlendFunc(gl::SRC1_COLOR, gl::ONE_MINUS_SRC1_COLOR); + + // Reset data and buffers + gl::BindBuffer(gl::ARRAY_BUFFER, 0); + gl::BindVertexArray(0); + + let padding_x = props.padding_x as i32; + let padding_y = props.padding_y as i32; + let width = props.width as i32; + let height = props.height as i32; + gl::Viewport(padding_x, padding_y, width - 2 * padding_x, height - 2 * padding_y); + + // Disable program + gl::UseProgram(0); + } + } + + pub fn with_api<F, T>( + &mut self, + config: &Config, + props: &term::SizeInfo, func: F, ) -> T where F: FnOnce(RenderApi<'_>) -> T, { - while let Ok(msg) = self.rx.try_recv() { - match msg { - Msg::ShaderReload => { - self.reload_shaders(PhysicalSize::new(f64::from(props.width), f64::from(props.height))); - } - } + // Flush message queue + if let Ok(Msg::ShaderReload) = self.rx.try_recv() { + let size = PhysicalSize::new(f64::from(props.width), f64::from(props.height)); + self.reload_shaders(size); } + while let Ok(_) = self.rx.try_recv() {} unsafe { - self.program.activate(); + gl::UseProgram(self.program.id); self.program.set_term_uniforms(props); - self.program.set_visual_bell(visual_bell_intensity as _); gl::BindVertexArray(self.vao); gl::BindBuffer(gl::ELEMENT_ARRAY_BUFFER, self.ebo); @@ -687,7 +777,6 @@ impl QuadRenderer { atlas: &mut self.atlas, current_atlas: &mut self.current_atlas, program: &mut self.program, - visual_bell_intensity: visual_bell_intensity as _, config, }); @@ -696,7 +785,7 @@ impl QuadRenderer { gl::BindBuffer(gl::ARRAY_BUFFER, 0); gl::BindVertexArray(0); - self.program.deactivate(); + gl::UseProgram(0); } res @@ -719,12 +808,13 @@ impl QuadRenderer { pub fn reload_shaders(&mut self, size: PhysicalSize) { warn!("Reloading shaders ..."); - let program = match ShaderProgram::new(size) { - Ok(program) => { + let result = (TextShaderProgram::new(size), RectShaderProgram::new()); + let (program, rect_program) = match result { + (Ok(program), Ok(rect_program)) => { warn!(" ... OK"); - program + (program, rect_program) } - Err(err) => { + (Err(err), _) | (_, Err(err)) => { match err { ShaderCreationError::Io(err) => { error!("Error reading shader file: {}", err); @@ -743,6 +833,7 @@ impl QuadRenderer { self.active_tex = 0; self.program = program; + self.rect_program = rect_program; } pub fn resize(&mut self, size: PhysicalSize, padding_x: f32, padding_y: f32) { @@ -755,12 +846,72 @@ impl QuadRenderer { let padding_x = padding_x as i32; let padding_y = padding_y as i32; gl::Viewport(padding_x, padding_y, width - 2 * padding_x, height - 2 * padding_y); + + // update projection + gl::UseProgram(self.program.id); + self.program.update_projection( + width as f32, + height as f32, + padding_x as f32, + padding_y as f32, + ); + gl::UseProgram(0); } + } + + // Render a rectangle + // + // This requires the rectangle program to be activated + fn render_rect(&mut self, rect: &Rect<f32>, color: Rgb, alpha: f32, size: &term::SizeInfo) { + // Do nothing when alpha is fully transparent + if alpha == 0. { + return; + } + + // Calculate rectangle position + let center_x = size.width / 2.; + let center_y = size.height / 2.; + let x = (rect.x - center_x) / center_x; + let y = -(rect.y - center_y) / center_y; + let width = rect.width / center_x; + let height = rect.height / center_y; + + unsafe { + // Setup vertices + let vertices: [f32; 12] = [ + x + width, y , 0.0, + x + width, y - height, 0.0, + x , y - height, 0.0, + x , y , 0.0, + ]; + + // Load vertex data into array buffer + gl::BufferData( + gl::ARRAY_BUFFER, + (size_of::<f32>() * vertices.len()) as _, + vertices.as_ptr() as *const _, + gl::STATIC_DRAW + ); + + // Color + self.rect_program.set_color(color, alpha); + + // Draw the rectangle + gl::DrawElements(gl::TRIANGLES, 6, gl::UNSIGNED_INT, ptr::null()); + } + } +} + +struct Rect<T> { + x: T, + y: T, + width: T, + height: T, +} - // update projection - self.program.activate(); - self.program.update_projection(width as f32, height as f32, padding_x, padding_y); - self.program.deactivate(); +impl<T> Rect<T> { + fn new(x: T, y: T, width: T, height: T) -> Self { + Rect { x, y, width, height } } } @@ -769,11 +920,11 @@ impl<'a> RenderApi<'a> { let alpha = self.config.background_opacity().get(); unsafe { gl::ClearColor( - (self.visual_bell_intensity + f32::from(color.r) / 255.0).min(1.0) * alpha, - (self.visual_bell_intensity + f32::from(color.g) / 255.0).min(1.0) * alpha, - (self.visual_bell_intensity + f32::from(color.b) / 255.0).min(1.0) * alpha, - alpha - ); + (f32::from(color.r) / 255.0).min(1.0) * alpha, + (f32::from(color.g) / 255.0).min(1.0) * alpha, + (f32::from(color.b) / 255.0).min(1.0) * alpha, + alpha, + ); gl::Clear(gl::COLOR_BUFFER_BIT); } } @@ -1012,39 +1163,20 @@ impl<'a> Drop for RenderApi<'a> { } } -impl ShaderProgram { - pub fn activate(&self) { - unsafe { - gl::UseProgram(self.id); - } - } - - pub fn deactivate(&self) { - unsafe { - gl::UseProgram(0); - } - } - - pub fn new(size: PhysicalSize) -> Result<ShaderProgram, ShaderCreationError> { - let vertex_source = if cfg!(feature = "live-shader-reload") { - None +impl TextShaderProgram { + pub fn new(size: PhysicalSize) -> Result<TextShaderProgram, ShaderCreationError> { + let (vertex_src, fragment_src) = if cfg!(feature = "live-shader-reload") { + (None, None) } else { - Some(TEXT_SHADER_V) + (Some(TEXT_SHADER_V), Some(TEXT_SHADER_F)) }; - let vertex_shader = - ShaderProgram::create_shader(TEXT_SHADER_V_PATH, gl::VERTEX_SHADER, vertex_source)?; - let frag_source = if cfg!(feature = "live-shader-reload") { - None - } else { - Some(TEXT_SHADER_F) - }; - let fragment_shader = - ShaderProgram::create_shader(TEXT_SHADER_F_PATH, gl::FRAGMENT_SHADER, frag_source)?; - let program = ShaderProgram::create_program(vertex_shader, fragment_shader)?; + let vertex_shader = create_shader(TEXT_SHADER_V_PATH, gl::VERTEX_SHADER, vertex_src)?; + let fragment_shader = create_shader(TEXT_SHADER_F_PATH, gl::FRAGMENT_SHADER, fragment_src)?; + let program = create_program(vertex_shader, fragment_shader)?; unsafe { - gl::DeleteShader(vertex_shader); gl::DeleteShader(fragment_shader); + gl::DeleteShader(vertex_shader); gl::UseProgram(program); } @@ -1063,30 +1195,28 @@ impl ShaderProgram { } // get uniform locations - let (projection, term_dim, cell_dim, visual_bell, background) = unsafe { + let (projection, term_dim, cell_dim, background) = unsafe { ( gl::GetUniformLocation(program, cptr!(b"projection\0")), gl::GetUniformLocation(program, cptr!(b"termDim\0")), gl::GetUniformLocation(program, cptr!(b"cellDim\0")), - gl::GetUniformLocation(program, cptr!(b"visualBell\0")), gl::GetUniformLocation(program, cptr!(b"backgroundPass\0")), ) }; assert_uniform_valid!(projection, term_dim, cell_dim); - let shader = ShaderProgram { + let shader = TextShaderProgram { id: program, u_projection: projection, u_term_dim: term_dim, u_cell_dim: cell_dim, - u_visual_bell: visual_bell, u_background: background, }; shader.update_projection(size.width as f32, size.height as f32, 0., 0.); - shader.deactivate(); + unsafe { gl::UseProgram(0); } Ok(shader) } @@ -1133,12 +1263,6 @@ impl ShaderProgram { } } - fn set_visual_bell(&self, visual_bell: f32) { - unsafe { - gl::Uniform1f(self.u_visual_bell, visual_bell); - } - } - fn set_background_pass(&self, background_pass: bool) { let value = if background_pass { 1 } else { 0 }; @@ -1146,69 +1270,70 @@ impl ShaderProgram { gl::Uniform1i(self.u_background, value); } } +} - fn create_program(vertex: GLuint, fragment: GLuint) -> Result<GLuint, ShaderCreationError> { +impl Drop for TextShaderProgram { + fn drop(&mut self) { unsafe { - let program = gl::CreateProgram(); - gl::AttachShader(program, vertex); - gl::AttachShader(program, fragment); - gl::LinkProgram(program); - - let mut success: GLint = 0; - gl::GetProgramiv(program, gl::LINK_STATUS, &mut success); - - if success == i32::from(gl::TRUE) { - Ok(program) - } else { - Err(ShaderCreationError::Link(get_program_info_log(program))) - } + gl::DeleteProgram(self.id); } } +} - fn create_shader( - path: &str, - kind: GLenum, - source: Option<&'static str>, - ) -> Result<GLuint, ShaderCreationError> { - let from_disk; - let source = if let Some(src) = source { - src +impl RectShaderProgram { + pub fn new() -> Result<Self, ShaderCreationError> { + let (vertex_src, fragment_src) = if cfg!(feature = "live-shader-reload") { + (None, None) } else { - from_disk = read_file(path)?; - &from_disk[..] + (Some(RECT_SHADER_V), Some(RECT_SHADER_F)) }; + let vertex_shader = create_shader( + RECT_SHADER_V_PATH, + gl::VERTEX_SHADER, + vertex_src + )?; + let fragment_shader = create_shader( + RECT_SHADER_F_PATH, + gl::FRAGMENT_SHADER, + fragment_src + )?; + let program = create_program(vertex_shader, fragment_shader)?; - let len: [GLint; 1] = [source.len() as GLint]; + unsafe { + gl::DeleteShader(fragment_shader); + gl::DeleteShader(vertex_shader); + gl::UseProgram(program); + } - let shader = unsafe { - let shader = gl::CreateShader(kind); - gl::ShaderSource(shader, 1, &(source.as_ptr() as *const _), len.as_ptr()); - gl::CompileShader(shader); - shader + // get uniform locations + let u_col = unsafe { + gl::GetUniformLocation(program, b"col\0".as_ptr() as *const _) }; - let mut success: GLint = 0; - unsafe { - gl::GetShaderiv(shader, gl::COMPILE_STATUS, &mut success); - } + let shader = RectShaderProgram { + id: program, + u_col, + }; - if success == GLint::from(gl::TRUE) { - Ok(shader) - } else { - // Read log - let log = get_shader_info_log(shader); + unsafe { gl::UseProgram(0) } - // Cleanup - unsafe { - gl::DeleteShader(shader); - } + Ok(shader) + } - Err(ShaderCreationError::Compile(PathBuf::from(path), log)) + fn set_color(&self, color: Rgb, alpha: f32) { + unsafe { + gl::Uniform4f( + self.u_col, + f32::from(color.r) / 255., + f32::from(color.g) / 255., + f32::from(color.b) / 255., + alpha, + ); } } } -impl Drop for ShaderProgram { +impl Drop for RectShaderProgram { fn drop(&mut self) { unsafe { gl::DeleteProgram(self.id); @@ -1216,6 +1341,62 @@ impl Drop for ShaderProgram { } } +fn create_program(vertex: GLuint, fragment: GLuint) -> Result<GLuint, ShaderCreationError> { + unsafe { + let program = gl::CreateProgram(); + gl::AttachShader(program, vertex); + gl::AttachShader(program, fragment); + gl::LinkProgram(program); + + let mut success: GLint = 0; + gl::GetProgramiv(program, gl::LINK_STATUS, &mut success); + + if success == i32::from(gl::TRUE) { + Ok(program) + } else { + Err(ShaderCreationError::Link(get_program_info_log(program))) + } + } +} + +fn create_shader(path: &str, kind: GLenum, source: Option<&'static str>) + -> Result<GLuint, ShaderCreationError> +{ + let from_disk; + let source = if let Some(src) = source { + src + } else { + from_disk = read_file(path)?; + &from_disk[..] + }; + + let len: [GLint; 1] = [source.len() as GLint]; + + let shader = unsafe { + let shader = gl::CreateShader(kind); + gl::ShaderSource(shader, 1, &(source.as_ptr() as *const _), len.as_ptr()); + gl::CompileShader(shader); + shader + }; + + let mut success: GLint = 0; + unsafe { + gl::GetShaderiv(shader, gl::COMPILE_STATUS, &mut success); + } + + if success == GLint::from(gl::TRUE) { + Ok(shader) + } else { + // Read log + let log = get_shader_info_log(shader); + + // Cleanup + unsafe { gl::DeleteShader(shader); } + + Err(ShaderCreationError::Compile(PathBuf::from(path), log)) + } +} + fn get_program_info_log(program: GLuint) -> String { // Get expected log length let mut max_length: GLint = 0; |