summaryrefslogtreecommitdiff
path: root/src/grid/mod.rs
diff options
context:
space:
mode:
authorChristian Duerr <contact@christianduerr.com>2018-05-01 20:07:59 +0200
committerJoe Wilm <joe@jwilm.com>2018-06-02 09:56:50 -0700
commiteabd6bb95b1ab883bdec16f8c307432c1e7c73d5 (patch)
tree97e775b91917011973aaf48a1929f02559ead64b /src/grid/mod.rs
parenta3c6c1db63af8dea62146739dc183c05b26b56d6 (diff)
downloadalacritty-eabd6bb95b1ab883bdec16f8c307432c1e7c73d5.tar.gz
alacritty-eabd6bb95b1ab883bdec16f8c307432c1e7c73d5.zip
Remove `push` from `Storage`
Since every line is allocated at startup anyways, the `push` method on `Storage` has been removed and instead of pushing to the vector the initialization has been moved to the `with_capacity` method. This has the advantage that we don't need to keep track of the `len` in push (like adding one), but we just need to worry about growing/shrinking the visible area.
Diffstat (limited to 'src/grid/mod.rs')
-rw-r--r--src/grid/mod.rs12
1 files changed, 1 insertions, 11 deletions
diff --git a/src/grid/mod.rs b/src/grid/mod.rs
index 87ac3d05..803f1e6e 100644
--- a/src/grid/mod.rs
+++ b/src/grid/mod.rs
@@ -118,17 +118,7 @@ pub enum Scroll {
impl<T: Copy + Clone> Grid<T> {
pub fn new(lines: index::Line, cols: index::Column, scrollback: usize, template: T) -> Grid<T> {
- let mut raw = Storage::with_capacity(*lines + scrollback, lines);
-
- // Allocate all lines in the buffer, including scrollback history
- //
- // TODO (jwilm) Allocating each line at this point is expensive and
- // delays startup. A nice solution might be having `Row` delay
- // allocation until it's actually used.
- for _ in 0..raw.len() {
- raw.push(Row::new(cols, &template));
- }
-
+ let raw = Storage::with_capacity(*lines + scrollback, lines, Row::new(cols, &template));
Grid {
raw,
cols,