diff options
| author | Christian Duerr <contact@christianduerr.com> | 2020-12-05 09:03:03 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-12-05 12:03:03 +0300 |
| commit | 9e71002e40d5487c6fa2571a3a3c4f5c8f679334 (patch) | |
| tree | 4704bcd1029b0b236967e1ffc8be49e36a235440 | |
| parent | de9ed259667588285891eda1665cd3edefcd3297 (diff) | |
| download | alacritty-9e71002e40d5487c6fa2571a3a3c4f5c8f679334.tar.gz alacritty-9e71002e40d5487c6fa2571a3a3c4f5c8f679334.zip | |
Fix dimming of indexed colors
It seems like the list of colors might have changed a bit, leading to
indexed colors not being transformed into their dim colors correctly.
To prevent this from happening in the future, the dimming for colors in
the range '0..=7' is now performed by offsetting them from the
'NamedColor::DimBlack'. Since this is the first dimmed color, this
should always work as long as all dimmed colors are added in the correct
order.
| -rw-r--r-- | CHANGELOG.md | 1 | ||||
| -rw-r--r-- | alacritty_terminal/src/term/mod.rs | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index cd4f43e6..34dde984 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - Wide characters sometimes being cut off - Preserve vi mode across terminal `reset` - Escapes `CSI Ps b` and `CSI Ps Z` with large parameters locking up Alacritty +- Dimming colors which use the indexed `CSI 38 : 5 : Ps m` notation ### Removed diff --git a/alacritty_terminal/src/term/mod.rs b/alacritty_terminal/src/term/mod.rs index b9e21205..154a24a2 100644 --- a/alacritty_terminal/src/term/mod.rs +++ b/alacritty_terminal/src/term/mod.rs @@ -401,7 +401,7 @@ impl RenderableCell { ) { (true, Flags::BOLD, 0..=7) => idx as usize + 8, (false, Flags::DIM, 8..=15) => idx as usize - 8, - (false, Flags::DIM, 0..=7) => idx as usize + 260, + (false, Flags::DIM, 0..=7) => NamedColor::DimBlack as usize + idx as usize, _ => idx as usize, }; |