summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Duerr <contact@christianduerr.com>2020-10-30 06:22:13 +0000
committerGitHub <noreply@github.com>2020-10-30 09:22:13 +0300
commit9028fb451a967d69a9e258a083ba64b052a9a5dd (patch)
tree684f28002202fec3a2891ea75da00bfed393dfbc
parentbede5d5d1c19da32a0b7fd0cb4ab9e369aa94eb8 (diff)
downloadalacritty-9028fb451a967d69a9e258a083ba64b052a9a5dd.tar.gz
alacritty-9028fb451a967d69a9e258a083ba64b052a9a5dd.zip
Fix visual bell getting stuck
This resolves a problem with the visual bell where it would not automatically trigger a redraw itself after the initial frame has been rendered. Since the unit of the visual bell duration is also unclear, it has been clarified.
-rw-r--r--CHANGELOG.md1
-rw-r--r--alacritty.yml4
-rw-r--r--alacritty/src/event.rs2
3 files changed, 5 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index f9c71df0..35d3b92f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -68,6 +68,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Feature checking when cross compiling between different operating systems
- Crash when writing to the clipboard fails on Wayland
- Crash with large negative `font.offset.x/y`
+- Visual bell getting stuck on the first frame
## 0.5.0
diff --git a/alacritty.yml b/alacritty.yml
index 8398235d..0b2d5365 100644
--- a/alacritty.yml
+++ b/alacritty.yml
@@ -297,8 +297,8 @@
# - Linear
#animation: EaseOutExpo
- # Duration of the visual bell flash. A `duration` of `0` will disable the
- # visual bell animation.
+ # Duration of the visual bell flash in milliseconds. A `duration` of `0` will
+ # disable the visual bell animation.
#duration: 0
# Visual bell animation color.
diff --git a/alacritty/src/event.rs b/alacritty/src/event.rs
index 7c3e786d..6c5318f6 100644
--- a/alacritty/src/event.rs
+++ b/alacritty/src/event.rs
@@ -874,6 +874,8 @@ impl<N: Notify + OnResize> Processor<N> {
if !terminal.visual_bell.completed() {
let event: Event = TerminalEvent::Wakeup.into();
self.event_queue.push(event.into());
+
+ *control_flow = ControlFlow::Poll;
}
// Redraw screen.