summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBarret Rennie <barret@brennie.ca>2018-12-02 11:11:51 -0500
committerChristian Duerr <chrisduerr@users.noreply.github.com>2018-12-02 16:11:51 +0000
commitca9a259caa59e48db3bdfdf021ee26c8bb85be99 (patch)
treeb00bf0b62dbc8fc9ba67dda75230c690f3197469
parente690a1444e110585a3b9ac1c97115004791726c5 (diff)
downloadalacritty-ca9a259caa59e48db3bdfdf021ee26c8bb85be99.tar.gz
alacritty-ca9a259caa59e48db3bdfdf021ee26c8bb85be99.zip
Request user attention when bell received in macOS
We now request the user's attention in macOS when a visual bell character is received. This manifests as the window jumping up and down in the dock.
-rw-r--r--CHANGELOG.md1
-rw-r--r--src/window.rs17
2 files changed, 8 insertions, 10 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8ffafb12..886fbfe2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- New configuration option `persistent_logging` and CLI flag `--persistent-logging`,
for keeping the log file after closing Alacritty
- `ClearLogNotice` action for removing the warning and error message
+- Terminal bells on macOS will now request the user's attention in the window
- Alacritty now requests privacy permissions on macOS
### Changed
diff --git a/src/window.rs b/src/window.rs
index de3eb9a6..82d465f2 100644
--- a/src/window.rs
+++ b/src/window.rs
@@ -361,16 +361,13 @@ impl Window {
self.window.set_urgent(is_urgent);
}
- #[cfg(
- not(
- any(
- target_os = "linux",
- target_os = "freebsd",
- target_os = "dragonfly",
- target_os = "openbsd"
- )
- )
- )]
+ #[cfg(target_os = "macos")]
+ pub fn set_urgent(&self, is_urgent: bool) {
+ use glutin::os::macos::WindowExt;
+ self.window.request_user_attention(is_urgent);
+ }
+
+ #[cfg(windows)]
pub fn set_urgent(&self, _is_urgent: bool) {}
pub fn set_ime_spot(&self, pos: LogicalPosition) {