summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Duerr <chrisduerr@users.noreply.github.com>2019-06-28 20:19:15 +0000
committerGitHub <noreply@github.com>2019-06-28 20:19:15 +0000
commitaf30f3735a5e402509cb14b994576d0ea4799557 (patch)
tree057362d4a8042b44eaa9ff116a4d6ef41fff4fc1
parent0815774cbfb9d1421b8077d5d9d641faf5f818c1 (diff)
downloadalacritty-af30f3735a5e402509cb14b994576d0ea4799557.tar.gz
alacritty-af30f3735a5e402509cb14b994576d0ea4799557.zip
Fix rows only resetting partially
This resolves an issue with rows only resetting partially, based on their `occ` state. However this state is not always accurate, so more than just the occupied elements need to be cleared. Fixes #2340.
-rw-r--r--CHANGELOG.md1
-rw-r--r--alacritty_terminal/src/grid/row.rs3
2 files changed, 2 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0602efa7..7d3007a5 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Performance issues while resizing Alacritty
- First unfullscreen action ignored on window launched in fullscreen mode
- The window is now filled with the background color before displaying
+- Cells sometimes not getting cleared correctly
## 0.3.3
diff --git a/alacritty_terminal/src/grid/row.rs b/alacritty_terminal/src/grid/row.rs
index 88a23871..b67f8cd4 100644
--- a/alacritty_terminal/src/grid/row.rs
+++ b/alacritty_terminal/src/grid/row.rs
@@ -80,9 +80,8 @@ impl<T: Copy> Row<T> {
}
/// Resets contents to the contents of `other`
- #[inline(never)]
pub fn reset(&mut self, other: &T) {
- for item in &mut self.inner[..self.occ] {
+ for item in &mut self.inner[..] {
*item = *other;
}
self.occ = 0;