aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Duerr <contact@christianduerr.com>2018-03-09 17:57:24 +0100
committerJoe Wilm <jwilm@users.noreply.github.com>2018-03-09 09:47:21 -0800
commite472aa0cb4d8072dd559633a0c84cc50bdb07693 (patch)
tree75b4899d208d4aae634334a1a603966330df361e
parent52ebf3e6ec33309999c19fe25d27ce0f5a8887b2 (diff)
downloadalacritty-e472aa0cb4d8072dd559633a0c84cc50bdb07693.tar.gz
alacritty-e472aa0cb4d8072dd559633a0c84cc50bdb07693.zip
Provide correct default for scroll_history
When implementing fallback to the default value with an u32 you will get 0 as the default value. However the default scrollback value is 10_000. A custom deserializer has been implemented which automatically falls back to the correct default value.
-rw-r--r--src/config.rs14
1 files changed, 13 insertions, 1 deletions
diff --git a/src/config.rs b/src/config.rs
index cc4e7eee..a6d67b4a 100644
--- a/src/config.rs
+++ b/src/config.rs
@@ -398,7 +398,7 @@ pub struct Config {
tabspaces: usize,
/// How much scrolling history to keep
- #[serde(default="default_scroll_history", deserialize_with="failure_default")]
+ #[serde(default="default_scroll_history", deserialize_with="deserialize_scroll_history")]
scroll_history: u32,
}
@@ -406,6 +406,18 @@ fn default_scroll_history() -> u32 {
10_000
}
+fn deserialize_scroll_history<'a, D>(deserializer: D) -> ::std::result::Result<u32, D::Error>
+ where D: de::Deserializer<'a>
+{
+ match u32::deserialize(deserializer) {
+ Ok(lines) => Ok(lines),
+ Err(err) => {
+ eprintln!("problem with config: {}; Using default value", err);
+ Ok(default_scroll_history())
+ },
+ }
+}
+
fn failure_default_vec<'a, D, T>(deserializer: D) -> ::std::result::Result<Vec<T>, D::Error>
where D: de::Deserializer<'a>,
T: Deserialize<'a>